Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2957413002: Info Memory: Implement dummy ServiceAccount() (Closed)

Created:
3 years, 5 months ago by Ryan Tseng
Modified:
3 years, 5 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M impl/memory/info.go View 1 1 chunk +4 lines, -0 lines 0 comments Download
M impl/memory/info_test.go View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
Ryan Tseng
ptal, used for some tests in a later CL
3 years, 5 months ago (2017-06-28 22:12:27 UTC) #4
iannucci
lgtm https://codereview.chromium.org/2957413002/diff/1/impl/memory/info.go File impl/memory/info.go (right): https://codereview.chromium.org/2957413002/diff/1/impl/memory/info.go#newcode97 impl/memory/info.go:97: return "user@example.com", nil maybe gae_service_account@example.com To distinguish it ...
3 years, 5 months ago (2017-06-28 22:19:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2957413002/20001
3 years, 5 months ago (2017-07-06 00:21:59 UTC) #14
commit-bot: I haz the power
3 years, 5 months ago (2017-07-06 00:25:29 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/gae/commit/e593adff12097f50cee06ce6a9f0a659153ceee4

Powered by Google App Engine
This is Rietveld 408576698