Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2957383002: [Cleanup] Use a sequence checker rather than a thread checker for the metrics service. (Closed)

Created:
3 years, 5 months ago by Ilya Sherman
Modified:
3 years, 5 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cleanup] Use a sequence checker rather than a thread checker for the metrics service. BUG=667892 TEST=none R=asvitkine@chromium.org Review-Url: https://codereview.chromium.org/2957383002 Cr-Commit-Position: refs/heads/master@{#483177} Committed: https://chromium.googlesource.com/chromium/src/+/8c542b721769c8eea65fd1be790f66cb77768913

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M chrome/browser/metrics/chrome_metrics_service_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_client.cc View 6 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Ilya Sherman
3 years, 5 months ago (2017-06-28 21:15:33 UTC) #1
Alexei Svitkine (slow)
lgtm
3 years, 5 months ago (2017-06-28 21:17:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2957383002/1
3 years, 5 months ago (2017-06-28 21:24:05 UTC) #7
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 22:40:46 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8c542b721769c8eea65fd1be790f...

Powered by Google App Engine
This is Rietveld 408576698