Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2957373002: cc: Don't touch layer state during painting. (Closed)

Created:
3 years, 5 months ago by Khushal
Modified:
3 years, 5 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Don't touch layer state during painting. The state on Layers, including property tree state, should not be changed during painting. Change DHCECKs for it to CHECKs at a few places to diagnose a crash. BUG=726423 R=enne@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2957373002 Cr-Commit-Position: refs/heads/master@{#483174} Committed: https://chromium.googlesource.com/chromium/src/+/ac130a51d426be4e44cf2d8743e284cbd360e408

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M cc/layers/layer.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Khushal
3 years, 5 months ago (2017-06-28 20:54:38 UTC) #2
enne (OOO)
lgtm
3 years, 5 months ago (2017-06-28 21:02:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2957373002/1
3 years, 5 months ago (2017-06-28 21:04:36 UTC) #5
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 22:28:09 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ac130a51d426be4e44cf2d8743e2...

Powered by Google App Engine
This is Rietveld 408576698