Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2957353002: Stop checking include order in PRESUBMIT.py (Closed)

Created:
3 years, 5 months ago by Nico
Modified:
3 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, marja
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop checking include order in PRESUBMIT.py Nowadays, clang-format checks for this already. BUG=688155 Review-Url: https://codereview.chromium.org/2957353002 Cr-Commit-Position: refs/heads/master@{#483125} Committed: https://chromium.googlesource.com/chromium/src/+/550aa3df793999b28a48c0bbc1694ffe0203b15c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -399 lines) Patch
M PRESUBMIT.py View 2 chunks +0 lines, -160 lines 0 comments Download
M PRESUBMIT_test.py View 1 chunk +0 lines, -239 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Nico
3 years, 5 months ago (2017-06-28 18:39:39 UTC) #2
Dirk Pranke
lgtm
3 years, 5 months ago (2017-06-28 20:33:26 UTC) #7
Dirk Pranke
nice!
3 years, 5 months ago (2017-06-28 20:33:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2957353002/1
3 years, 5 months ago (2017-06-28 20:34:12 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 20:41:49 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/550aa3df793999b28a48c0bbc169...

Powered by Google App Engine
This is Rietveld 408576698