|
|
Created:
3 years, 5 months ago by Elliot Glaysher Modified:
3 years, 5 months ago Reviewers:
James Cook CC:
chromium-reviews, kalyank, sadrul Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionMake ShellPortMash dispatch to cursor_manager in mus mode.
In mus mode, we forward commands to the window manager for the actual
rendering of cursors, but the monolith ash/chrome process otherwise
doesn't change. When in mus mode, ShellPort commands should be
dispatched to our local cursor_manager(), so that things which read back
the cursor state return the correct values.
They should only dispatch directly to the window manager in mash mode.
BUG=734806
Review-Url: https://codereview.chromium.org/2957313003
Cr-Commit-Position: refs/heads/master@{#483500}
Committed: https://chromium.googlesource.com/chromium/src/+/97ea635cc998b3d39de0c08695b8a8feb3aa974f
Patch Set 1 #Patch Set 2 : Make NativeCursorManagerAshMus responsible for calling the window manager. #Patch Set 3 : Simplify NativeCursorManagerAshMus changes. #Patch Set 4 : Rebase to ToT #
Total comments: 3
Patch Set 5 : Check GetAshConfig() #
Messages
Total messages: 31 (26 generated)
The CQ bit was checked by erg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by erg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by erg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Description was changed from ========== Make ShellPortMash also dispatch to cursor_manager in mus mode. This isn't the correct thing long term; when we start working on mash again, we'll want to work on deprecating the cursor manager so that we rely on mus to be the canonical source of state. BUG=734806 ========== to ========== Make ShellPortMash dispatch to cursor_manager in mus mode. In mus mode, we forward commands to the window manager for the actual rendering of cursors, but the monolith ash/chrome process otherwise doesn't change. When in mus mode, ShellPort commands should be dispatched to our local cursor_manager(), so that things which read back the cursor state return the correct values. They should only dispatch directly to the window manager in mash mode. BUG=734806 ==========
The CQ bit was checked by erg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
erg@chromium.org changed reviewers: + jamescook@chromium.org
LGTM with nit https://codereview.chromium.org/2957313003/diff/60001/ash/mus/bridge/shell_po... File ash/mus/bridge/shell_port_mash.cc (right): https://codereview.chromium.org/2957313003/diff/60001/ash/mus/bridge/shell_po... ash/mus/bridge/shell_port_mash.cc:138: if (mus_state_) nit: I think these if()s would be clearer if they called GetAshConfig() to check the mode. https://codereview.chromium.org/2957313003/diff/60001/testing/buildbot/filter... File testing/buildbot/filters/ash_unittests_mus.filter (left): https://codereview.chromium.org/2957313003/diff/60001/testing/buildbot/filter... testing/buildbot/filters/ash_unittests_mus.filter:1: # TODO: fix these. They fail because wm::CursorManager isn't created. Hooray!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by erg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2957313003/diff/60001/ash/mus/bridge/shell_po... File ash/mus/bridge/shell_port_mash.cc (right): https://codereview.chromium.org/2957313003/diff/60001/ash/mus/bridge/shell_po... ash/mus/bridge/shell_port_mash.cc:138: if (mus_state_) On 2017/06/29 19:43:24, James Cook wrote: > nit: I think these if()s would be clearer if they called GetAshConfig() to check > the mode. Done.
The CQ bit was checked by erg@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jamescook@chromium.org Link to the patchset: https://codereview.chromium.org/2957313003/#ps80001 (title: "Check GetAshConfig()")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 80001, "attempt_start_ts": 1498772380224580, "parent_rev": "56679d20bd6284ffe2a64224d33232cb1df4f0ba", "commit_rev": "97ea635cc998b3d39de0c08695b8a8feb3aa974f"}
Message was sent while issue was closed.
Description was changed from ========== Make ShellPortMash dispatch to cursor_manager in mus mode. In mus mode, we forward commands to the window manager for the actual rendering of cursors, but the monolith ash/chrome process otherwise doesn't change. When in mus mode, ShellPort commands should be dispatched to our local cursor_manager(), so that things which read back the cursor state return the correct values. They should only dispatch directly to the window manager in mash mode. BUG=734806 ========== to ========== Make ShellPortMash dispatch to cursor_manager in mus mode. In mus mode, we forward commands to the window manager for the actual rendering of cursors, but the monolith ash/chrome process otherwise doesn't change. When in mus mode, ShellPort commands should be dispatched to our local cursor_manager(), so that things which read back the cursor state return the correct values. They should only dispatch directly to the window manager in mash mode. BUG=734806 Review-Url: https://codereview.chromium.org/2957313003 Cr-Commit-Position: refs/heads/master@{#483500} Committed: https://chromium.googlesource.com/chromium/src/+/97ea635cc998b3d39de0c08695b8... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/97ea635cc998b3d39de0c08695b8... |