Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 2957313003: Make ShellPortMash also dispatch to cursor_manager in mus mode. (Closed)

Created:
3 years, 5 months ago by Elliot Glaysher
Modified:
3 years, 5 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make ShellPortMash dispatch to cursor_manager in mus mode. In mus mode, we forward commands to the window manager for the actual rendering of cursors, but the monolith ash/chrome process otherwise doesn't change. When in mus mode, ShellPort commands should be dispatched to our local cursor_manager(), so that things which read back the cursor state return the correct values. They should only dispatch directly to the window manager in mash mode. BUG=734806 Review-Url: https://codereview.chromium.org/2957313003 Cr-Commit-Position: refs/heads/master@{#483500} Committed: https://chromium.googlesource.com/chromium/src/+/97ea635cc998b3d39de0c08695b8a8feb3aa974f

Patch Set 1 #

Patch Set 2 : Make NativeCursorManagerAshMus responsible for calling the window manager. #

Patch Set 3 : Simplify NativeCursorManagerAshMus changes. #

Patch Set 4 : Rebase to ToT #

Total comments: 3

Patch Set 5 : Check GetAshConfig() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -19 lines) Patch
M ash/mus/bridge/shell_port_mash.cc View 1 2 3 4 1 chunk +25 lines, -5 lines 0 comments Download
M ash/wm/native_cursor_manager_ash_mus.cc View 1 2 4 chunks +4 lines, -7 lines 0 comments Download
M testing/buildbot/filters/ash_unittests_mus.filter View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 31 (26 generated)
Elliot Glaysher
3 years, 5 months ago (2017-06-29 19:35:29 UTC) #17
James Cook
LGTM with nit https://codereview.chromium.org/2957313003/diff/60001/ash/mus/bridge/shell_port_mash.cc File ash/mus/bridge/shell_port_mash.cc (right): https://codereview.chromium.org/2957313003/diff/60001/ash/mus/bridge/shell_port_mash.cc#newcode138 ash/mus/bridge/shell_port_mash.cc:138: if (mus_state_) nit: I think these ...
3 years, 5 months ago (2017-06-29 19:43:24 UTC) #18
Elliot Glaysher
https://codereview.chromium.org/2957313003/diff/60001/ash/mus/bridge/shell_port_mash.cc File ash/mus/bridge/shell_port_mash.cc (right): https://codereview.chromium.org/2957313003/diff/60001/ash/mus/bridge/shell_port_mash.cc#newcode138 ash/mus/bridge/shell_port_mash.cc:138: if (mus_state_) On 2017/06/29 19:43:24, James Cook wrote: > ...
3 years, 5 months ago (2017-06-29 21:39:36 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2957313003/80001
3 years, 5 months ago (2017-06-29 21:40:13 UTC) #28
commit-bot: I haz the power
3 years, 5 months ago (2017-06-29 21:45:24 UTC) #31
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/97ea635cc998b3d39de0c08695b8...

Powered by Google App Engine
This is Rietveld 408576698