Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2957313002: Inline Map::has_code_cache() into its one caller. (Closed)

Created:
3 years, 5 months ago by titzer
Modified:
3 years, 5 months ago
Reviewers:
ulan, Toon Verwaest
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office)
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Inline Map::has_code_cache() into its one caller. R=verwaest@chromium.org BUG= Review-Url: https://codereview.chromium.org/2957313002 Cr-Commit-Position: refs/heads/master@{#46310} Committed: https://chromium.googlesource.com/v8/v8/+/73ce185915963024dffc30cd69888d8425ebbc46

Patch Set 1 #

Patch Set 2 : Inline Map::has_code_cache() into its one caller. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -12 lines) Patch
M src/heap/object-stats.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects-inl.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
M src/objects/map.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
titzer
3 years, 5 months ago (2017-06-28 13:03:03 UTC) #1
Toon Verwaest
lgtm
3 years, 5 months ago (2017-06-28 15:03:07 UTC) #2
titzer
On 2017/06/28 15:03:07, Toon Verwaest wrote: > lgtm + ulan for heap
3 years, 5 months ago (2017-06-29 07:55:45 UTC) #5
ulan
heap lgtm
3 years, 5 months ago (2017-06-29 08:25:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2957313002/1
3 years, 5 months ago (2017-06-29 08:32:03 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/38405) v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED, ...
3 years, 5 months ago (2017-06-29 08:35:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2957313002/20001
3 years, 5 months ago (2017-06-29 09:10:48 UTC) #17
commit-bot: I haz the power
3 years, 5 months ago (2017-06-29 09:51:06 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/73ce185915963024dffc30cd69888d8425e...

Powered by Google App Engine
This is Rietveld 408576698