Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(37)

Issue 2957223002: TaskScheduler Migration for DownloadProtectionService. (Closed)

Created:
1 year, 11 months ago by Jialiu Lin
Modified:
1 year, 10 months ago
Reviewers:
lpz
CC:
chromium-reviews, grt+watch_chromium.org, vakh+watch_chromium.org, timvolodine
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

TaskSchedule Migration for DownloadProtectionService. Migrating: BlockingPool, BroserThreads::DB, FlushForTesting BUG=667892, 689520 Review-Url: https://codereview.chromium.org/2957223002 Cr-Commit-Position: refs/heads/master@{#483457} Committed: https://chromium.googlesource.com/chromium/src/+/70e2eed1827853f0f33119000deb6aa6e7fc74b0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -15 lines) Patch
M chrome/browser/safe_browsing/download_protection_service.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/download_protection_service_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/two_phase_uploader_unittest.cc View 7 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Jialiu Lin
TaskSchedule Migration based on this task assignment sheet: https://docs.google.com/spreadsheets/d/18x9PGMlfgWcBr4fDz2SEEtIwTpSjcBFT2Puib47ZF1w/edit?pli=1#gid=0
1 year, 11 months ago (2017-06-28 00:36:52 UTC) #6
Jialiu Lin
lpz, please take a look. More information about TaskScheduler migration can be found here: https://chromium.googlesource.com/chromium/src/+/master/docs/task_scheduler_migration.md
1 year, 10 months ago (2017-06-29 18:16:12 UTC) #9
lpz
lgtm
1 year, 10 months ago (2017-06-29 18:23:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2957223002/1
1 year, 10 months ago (2017-06-29 18:45:04 UTC) #12
commit-bot: I haz the power
1 year, 10 months ago (2017-06-29 19:55:02 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/70e2eed1827853f0f33119000deb...

Powered by Google App Engine
This is Rietveld 408576698