Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 2957093003: Don't fade in overlay scrollbar when user interacting the content under scrollbar. (Closed)

Created:
3 years, 5 months ago by bokan
Modified:
3 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Don't fade in overlay scrollbar when user interacting the content under scrollbar. The issue (crbug.com/719011) indicate that it is hard to interact with the content under the the scrollbar because the scrollbar will fade in while mouse moves in the hover fade in region of scrollbar. In this patch, we prevent fade in overlay scrollbar when user mouse down. 3 behaviors changed: 1. When mouse move in hover fade in region of scrollbar with mouse press, we don't trigger delay fade in. 2. When mouse down after a delay fade in triggered, cancel the delay fade in. 3. When mouse up in hover fade in region of scrollbar, trigger a delay fade in. BUG=719011 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2931703002 Cr-Original-Commit-Position: refs/heads/master@{#478733} Review-Url: https://codereview.chromium.org/2957093003 . Cr-Commit-Position: refs/branch-heads/3112@{#478} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/ec0cede7db7fada94b0d69a44d7f0e6c138ee877

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -14 lines) Patch
M cc/input/scrollbar_animation_controller.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/input/scrollbar_animation_controller.cc View 6 chunks +35 lines, -6 lines 0 comments Download
M cc/input/scrollbar_animation_controller_unittest.cc View 8 chunks +111 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
bokan
3 years, 5 months ago (2017-06-27 15:21:39 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ec0cede7db7fada94b0d69a44d7f0e6c138ee877.

Powered by Google App Engine
This is Rietveld 408576698