chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java - Issue 2957063002: Update app banner state machine to use more states.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

Issue 2957063002: Update app banner state machine to use more states. (Closed)

Patch Set: Feedback Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java ('k') | chrome/browser/android/banners/app_banner_manager_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

index 183bd0ead07195a7f3184d5cbf0ea8e984aed5df..9e3c250f18e62be55a142f3c227534bcda283acf 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

@@ -246,7 +246,7 @@ public class AppBannerManagerTest {

AppBannerManager manager =

mActivityTestRule.getActivity().getActivityTab().getAppBannerManager();

return mDetailsDelegate.mNumRetrieved == numExpected

- && !manager.isActiveForTesting();

+ && !manager.isRunningForTesting();

}

});

}

@@ -344,7 +344,7 @@ public class AppBannerManagerTest {

public boolean isSatisfied() {

AppBannerManager manager =

mActivityTestRule.getActivity().getActivityTab().getAppBannerManager();

- return !manager.isActiveForTesting();

+ return !manager.isRunningForTesting();

}

});

InfoBarUtil.waitUntilNoInfoBarsExist(mActivityTestRule.getInfoBars());

@@ -364,7 +364,7 @@ public class AppBannerManagerTest {

public boolean isSatisfied() {

AppBannerManager manager =

mActivityTestRule.getActivity().getActivityTab().getAppBannerManager();

- return !manager.isActiveForTesting();

+ return !manager.isRunningForTesting();

}

});

waitUntilAppBannerInfoBarAppears(expectedTitle);

@@ -656,7 +656,7 @@ public class AppBannerManagerTest {

public boolean isSatisfied() {

AppBannerManager manager =

mActivityTestRule.getActivity().getActivityTab().getAppBannerManager();

- return !manager.isActiveForTesting();

+ return !manager.isRunningForTesting();

}

});

waitUntilAppBannerInfoBarAppears(WEB_APP_TITLE);

@@ -678,7 +678,7 @@ public class AppBannerManagerTest {

public boolean isSatisfied() {

AppBannerManager manager =

mActivityTestRule.getActivity().getActivityTab().getAppBannerManager();

- return !manager.isActiveForTesting();

+ return !manager.isRunningForTesting();

}

});

Assert.assertTrue(mActivityTestRule.getInfoBars().isEmpty());