Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2830)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java

Issue 2957063002: Update app banner state machine to use more states. (Closed)
Patch Set: Feedback Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
index ce221b5561e76c651242feec419c73bbaedf1cdb..90d9441115e0bb3d10a3b2499aaff0290787ed79 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
@@ -156,8 +156,8 @@ public class AppBannerManager {
/** Returns whether the native AppBannerManager is working. */
@VisibleForTesting
- public boolean isActiveForTesting() {
- return nativeIsActiveForTesting(mNativePointer);
+ public boolean isRunningForTesting() {
+ return nativeIsRunningForTesting(mNativePointer);
}
/** Signal to native that the add to homescreen menu item was tapped for metrics purposes. */
@@ -202,7 +202,7 @@ public class AppBannerManager {
AppData data, String title, String packageName, String imageUrl);
// Testing methods.
- private native boolean nativeIsActiveForTesting(long nativeAppBannerManagerAndroid);
+ private native boolean nativeIsRunningForTesting(long nativeAppBannerManagerAndroid);
private static native void nativeSetDaysAfterDismissAndIgnoreToTrigger(
int dismissDays, int ignoreDays);
private static native void nativeSetTimeDeltaForTesting(int days);
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698