Update app banner state machine to use more states.

chrome/browser/android/banners/app_banner_manager_android.cc

Index: chrome/browser/android/banners/app_banner_manager_android.cc
diff --git a/chrome/browser/android/banners/app_banner_manager_android.cc b/chrome/browser/android/banners/app_banner_manager_android.cc
index 967a2758bc5c69bec129069421e97fe9a77b25c7..99908671fdd8b40a0cedc4bd6775f808eac88e5e 100644
--- a/chrome/browser/android/banners/app_banner_manager_android.cc
+++ b/chrome/browser/android/banners/app_banner_manager_android.cc
@@ -87,10 +87,10 @@ AppBannerManagerAndroid::GetJavaBannerManager() const {
   return java_banner_manager_;
 }
 
-bool AppBannerManagerAndroid::IsActiveForTesting(
+bool AppBannerManagerAndroid::IsRunningForTesting(
     JNIEnv* env,
     const JavaParamRef<jobject>& obj) {
-  return is_active();
+  return IsRunning();
 }
 
 void AppBannerManagerAndroid::RecordMenuOpen(JNIEnv* env,
@@ -227,9 +227,6 @@ void AppBannerManagerAndroid::OnAppIconFetched(const SkBitmap& bitmap) {
     Stop();

[dominickn, 2017/07/07 06:23:18]

You need to add return here I think.

[benwells, 2017/07/07 06:29:27]

Done.

   }
 
-  if (!is_active())
-    return;
-
   primary_icon_ = bitmap;
   SendBannerPromptRequest();
 }