Update app banner state machine to use more states.

chrome/browser/android/banners/app_banner_manager_android.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/banners/app_banner_manager_android.h"
 
 #include <memory>
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
@@ skipping 69 matching lines @@
   JNIEnv* env = base::android::AttachCurrentThread();
   Java_AppBannerManager_destroy(env, java_banner_manager_);
   java_banner_manager_.Reset();
 }
 
 const base::android::ScopedJavaGlobalRef<jobject>&
 AppBannerManagerAndroid::GetJavaBannerManager() const {
   return java_banner_manager_;
 }
 
-bool AppBannerManagerAndroid::IsActiveForTesting(
+bool AppBannerManagerAndroid::IsRunningForTesting(
     JNIEnv* env,
     const JavaParamRef<jobject>& obj) {
-  return is_active();
+  return IsRunning();
 }
 
 void AppBannerManagerAndroid::RecordMenuOpen(JNIEnv* env,
                                              const JavaParamRef<jobject>& obj) {
   manager()->RecordMenuOpenHistogram();
 }
 
 void AppBannerManagerAndroid::RecordMenuItemAddToHomescreen(
     JNIEnv* env,
     const JavaParamRef<jobject>& obj) {
@@ skipping 113 matching lines @@
     badge_icon_url_ = data.badge_icon_url;
     badge_icon_ = *data.badge_icon;
   }
 
   AppBannerManager::OnDidPerformInstallableCheck(data);
 }
 
 void AppBannerManagerAndroid::OnAppIconFetched(const SkBitmap& bitmap) {
   if (bitmap.drawsNothing()) {
     ReportStatus(web_contents(), NO_ICON_AVAILABLE);
     Stop();

[dominickn, 2017/07/07 06:23:18]

You need to add return here I think.

[benwells, 2017/07/07 06:29:27]

Done.

   }
 
-  if (!is_active())
-    return;
-
   primary_icon_ = bitmap;
   SendBannerPromptRequest();
 }
 
 void AppBannerManagerAndroid::ResetCurrentPageData() {
   AppBannerManager::ResetCurrentPageData();
   native_app_data_.Reset();
   native_app_package_ = "";
 }
 
@@ skipping 129 matching lines @@
 }
 
 // static
 void SetTotalEngagementToTrigger(JNIEnv* env,
                                  const JavaParamRef<jclass>& clazz,
                                  jdouble engagement) {
   AppBannerSettingsHelper::SetTotalEngagementToTrigger(engagement);
 }
 
 }  // namespace banners