Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2956973002: [Cronet] Export NSError constants instead of defining them in Cronet.h (Closed)

Created:
3 years, 5 months ago by mef
Modified:
3 years, 5 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, ios-reviews_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] Export NSError constants instead of defining them in Cronet.h BUG=670689 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2956973002 Cr-Commit-Position: refs/heads/master@{#482418} Committed: https://chromium.googlesource.com/chromium/src/+/a7ac5d97093331a18c69d16a2ebe82bde507c1bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M components/cronet/ios/Cronet.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/cronet/ios/Cronet.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
mef
PTAL. The FOUNDATION_EXPORT replaces 'extern' for mixed C/C++ environments.
3 years, 5 months ago (2017-06-26 19:16:26 UTC) #5
kapishnikov
lgtm
3 years, 5 months ago (2017-06-26 20:53:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2956973002/1
3 years, 5 months ago (2017-06-26 21:33:48 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-06-26 21:37:55 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a7ac5d97093331a18c69d16a2ebe...

Powered by Google App Engine
This is Rietveld 408576698