Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2956953002:
MD Settings: Tweak selected avatar border in selection grid. (Closed)
DescriptionMD Settings: Tweak selected avatar border in selection grid.
Per UX request, it should be 2px instead of 1px. Also removing unused
--avatar-selector-avatar-selected CSS mixin.
BUG=734789
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2956953002
Cr-Commit-Position: refs/heads/master@{#482450}
Committed: https://chromium.googlesource.com/chromium/src/+/16d4bfed7e1a4f29cdc9e471dbaaddfd12419e50
Patch Set 1 #Patch Set 2 : Remove unused variable #
Total comments: 3
Messages
Total messages: 17 (12 generated)
Description was changed from ========== MD Settings: Change selected avatar border in selection grid. Per UX it should be 2px instead of 1px. BUG=734789 ========== to ========== MD Settings: Change selected avatar border in selection grid. Per UX it should be 2px instead of 1px. BUG=734789 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== MD Settings: Change selected avatar border in selection grid. Per UX it should be 2px instead of 1px. BUG=734789 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Change selected avatar border in selection grid. Per UX request, it should be 2px instead of 1px. BUG=734789 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
dpapad@chromium.org changed reviewers: + dschuyler@chromium.org
Before/after screenshots at http://imgur.com/a/uP4fc. https://codereview.chromium.org/2956953002/diff/20001/ui/webui/resources/cr_e... File ui/webui/resources/cr_elements/cr_profile_avatar_selector/cr_profile_avatar_selector.html (left): https://codereview.chromium.org/2956953002/diff/20001/ui/webui/resources/cr_e... ui/webui/resources/cr_elements/cr_profile_avatar_selector/cr_profile_avatar_selector.html:42: @apply(--avatar-selector-avatar-selected); Looked for usages of this mixin and did not find anything, so removing it.
The CQ bit was checked by dpapad@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== MD Settings: Change selected avatar border in selection grid. Per UX request, it should be 2px instead of 1px. BUG=734789 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Tweak selected avatar border in selection grid. Per UX request, it should be 2px instead of 1px. BUG=734789 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2956953002/diff/20001/ui/webui/resources/cr_e... File ui/webui/resources/cr_elements/cr_profile_avatar_selector/cr_profile_avatar_selector.html (left): https://codereview.chromium.org/2956953002/diff/20001/ui/webui/resources/cr_e... ui/webui/resources/cr_elements/cr_profile_avatar_selector/cr_profile_avatar_selector.html:42: @apply(--avatar-selector-avatar-selected); On 2017/06/26 18:59:32, dpapad wrote: > Looked for usages of this mixin and did not find anything, so removing it. Please make a note in the CL description like (Removed used blah-blah).
Description was changed from ========== MD Settings: Tweak selected avatar border in selection grid. Per UX request, it should be 2px instead of 1px. BUG=734789 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Tweak selected avatar border in selection grid. Per UX request, it should be 2px instead of 1px. Also removing unused --avatar-selector-avatar-selected CSS mixin. BUG=734789 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
https://codereview.chromium.org/2956953002/diff/20001/ui/webui/resources/cr_e... File ui/webui/resources/cr_elements/cr_profile_avatar_selector/cr_profile_avatar_selector.html (left): https://codereview.chromium.org/2956953002/diff/20001/ui/webui/resources/cr_e... ui/webui/resources/cr_elements/cr_profile_avatar_selector/cr_profile_avatar_selector.html:42: @apply(--avatar-selector-avatar-selected); On 2017/06/26 at 22:39:12, dschuyler wrote: > On 2017/06/26 18:59:32, dpapad wrote: > > Looked for usages of this mixin and did not find anything, so removing it. > > Please make a note in the CL description like > (Removed used blah-blah). Done.
The CQ bit was checked by dpapad@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498517656443200,
"parent_rev": "c61269077f9faa81be6143fd2abb55d27e7d90d0", "commit_rev":
"16d4bfed7e1a4f29cdc9e471dbaaddfd12419e50"}
Message was sent while issue was closed.
Description was changed from ========== MD Settings: Tweak selected avatar border in selection grid. Per UX request, it should be 2px instead of 1px. Also removing unused --avatar-selector-avatar-selected CSS mixin. BUG=734789 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Tweak selected avatar border in selection grid. Per UX request, it should be 2px instead of 1px. Also removing unused --avatar-selector-avatar-selected CSS mixin. BUG=734789 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2956953002 Cr-Commit-Position: refs/heads/master@{#482450} Committed: https://chromium.googlesource.com/chromium/src/+/16d4bfed7e1a4f29cdc9e471dbaa... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/16d4bfed7e1a4f29cdc9e471dbaa... |
