Adding smarter resizing logic for the context menu on orientation changes

Adding smarter resizing logic for the context menu on orientation changes
and adding new maxes for width and height.


Renamed context_menu_height_padding to context_menu_min_vertical_padding with half the value, but multiplied all usages by 2 so the total values are the same.

Added context_menu_min_side_padding.

Rewrote sizing logic so width is the minimum of 500 dp or total width - 2 * side_padding

Added a max height to context menu row

Added a max height to the context menu so it no longer leaks over the edge.

The list view now scrolls when the context menu reaches max height.

BUG=731173

[Daniel Park, 2017-06-26 18:16:21]

The CQ bit was checked by danielpark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-26 18:16:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-26 19:00:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-26 19:00:27]

Dry run: This issue passed the CQ dry run.

[Daniel Park, 2017-06-26 19:51:06]

danielpark@chromium.org changed reviewers:
+ dfalcantara@chromium.org, tedchoc@chromium.org, twellington@chromium.org

[gone, 2017-06-26 21:17:29]

https://codereview.chromium.org/2956943002/diff/1/chrome/android/java/res/val...
File chrome/android/java/res/values/dimens.xml (right):

https://codereview.chromium.org/2956943002/diff/1/chrome/android/java/res/val...
chrome/android/java/res/values/dimens.xml:477: <dimen
name="context_menu_min_side_padding">20dp</dimen>
might as well just call this context_menu_min_padding

https://codereview.chromium.org/2956943002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuViewPager.java
(right):

https://codereview.chromium.org/2956943002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuViewPager.java:38:

This function needs more comments explaining what's going on.

https://codereview.chromium.org/2956943002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuViewPager.java:41:
getResources().getDimensionPixelSize(R.dimen.context_menu_min_side_padding);
Because they're constants, you should cache the side and vertical dimension
paddings out as member fields to prevent having to retrieve this every time the
view is measured.

[Daniel Park, 2017-06-26 21:45:59]

Description was changed from

==========
Adding smarter resizing logic for the context menu on orientation changes
and adding new maxes for width and height.


Renamed context_menu_height_padding to context_menu_min_vertical_padding with
half the value, but multiplied all usages by 2 so the total values are the same.

Added context_menu_min_side_padding.

Rewrote sizing logic so width is the minimum of 500 dp or total width - 2 *
side_padding

Added a max height to context menu row

Added a max height to the context menu so it no longer leaks over the edge.

The list view now scrolls when the context menu reaches max height.

BUG=731173
==========

to

==========
Adding smarter resizing logic for the context menu on orientation changes
and adding new maxes for width and height.


Renamed context_menu_height_padding to context_menu_min_vertical_padding with
half the value, but multiplied all usages by 2 so the total values are the same.

Added context_menu_min_side_padding.

Rewrote sizing logic so width is the minimum of 500 dp or total width - 2 *
side_padding

Added a max height to context menu row

Added a max height to the context menu so it no longer leaks over the edge.

The list view now scrolls when the context menu reaches max height.

BUG=731173
==========

[Daniel Park, 2017-06-26 21:51:23]

https://codereview.chromium.org/2956943002/diff/1/chrome/android/java/res/val...
File chrome/android/java/res/values/dimens.xml (right):

https://codereview.chromium.org/2956943002/diff/1/chrome/android/java/res/val...
chrome/android/java/res/values/dimens.xml:477: <dimen
name="context_menu_min_side_padding">20dp</dimen>
On 2017/06/26 21:17:29, dfalcantara wrote:
> might as well just call this context_menu_min_padding

Done.

https://codereview.chromium.org/2956943002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuViewPager.java
(right):

https://codereview.chromium.org/2956943002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuViewPager.java:38:

On 2017/06/26 21:17:29, dfalcantara wrote:
> This function needs more comments explaining what's going on.

Done.

https://codereview.chromium.org/2956943002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuViewPager.java:41:
getResources().getDimensionPixelSize(R.dimen.context_menu_min_side_padding);
On 2017/06/26 21:17:29, dfalcantara wrote:
> Because they're constants, you should cache the side and vertical dimension
> paddings out as member fields to prevent having to retrieve this every time
the
> view is measured.

Done.