chrome/android/java/res/values/dimens.xml - Issue 2956943002: Adding smarter resizing logic for the context menu on orientation changes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/values/dimens.xml

Issue 2956943002: Adding smarter resizing logic for the context menu on orientation changes (Closed)

Patch Set: Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/java/res/layout/tabular_context_menu_row.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuViewPager.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuViewPager.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file. -->	4 found in the LICENSE file. -->

5	5

6 <resources>	6 <resources>

7 <!-- Connection info popup dimensions -->	7 <!-- Connection info popup dimensions -->

8 <dimen name="connection_info_padding_wide">24dp</dimen>	8 <dimen name="connection_info_padding_wide">24dp</dimen>

9 <dimen name="connection_info_padding_thin">16dp</dimen>	9 <dimen name="connection_info_padding_thin">16dp</dimen>

10	10

(...skipping 455 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
466 <dimen name="list_item_lateral_padding">1dp</dimen>	466 <dimen name="list_item_lateral_padding">1dp</dimen>

467 <dimen name="list_item_default_margin">16dp</dimen>	467 <dimen name="list_item_default_margin">16dp</dimen>

468 <dimen name="signin_and_sync_view_padding">16dp</dimen>	468 <dimen name="signin_and_sync_view_padding">16dp</dimen>

469 <dimen name="sad_tab_bullet_gap">12dp</dimen>	469 <dimen name="sad_tab_bullet_gap">12dp</dimen>

470 <dimen name="sad_tab_bullet_leading_offset">1dp</dimen>	470 <dimen name="sad_tab_bullet_leading_offset">1dp</dimen>

471	471

472 <!-- Context Menu Dimensions -->	472 <!-- Context Menu Dimensions -->

473 <dimen name="context_menu_header_image_min_size">56dp</dimen>	473 <dimen name="context_menu_header_image_min_size">56dp</dimen>

474 <dimen name="context_menu_header_image_max_size">56dp</dimen>	474 <dimen name="context_menu_header_image_max_size">56dp</dimen>

475 <dimen name="context_menu_max_width">500dp</dimen>	475 <dimen name="context_menu_max_width">500dp</dimen>

	476 <dimen name="context_menu_min_vertical_padding">20dp</dimen>

	477 <dimen name="context_menu_min_side_padding">20dp</dimen>
	gone 2017/06/26 21:17:29 might as well just call this context_menu_min_padd might as well just call this context_menu_min_padding Daniel Park 2017/06/26 21:51:22 Done. Show quoted text On 2017/06/26 21:17:29, dfalcantara wrote: > might as well just call this context_menu_min_padding Done.
476	478

477 <!-- Divider Dimensions -->	479 <!-- Divider Dimensions -->

478 <dimen name="divider_height">1dp</dimen>	480 <dimen name="divider_height">1dp</dimen>

479	481

480 <!-- Search widget dimensions -->	482 <!-- Search widget dimensions -->

481 <dimen name="search_activity_location_bar_margin_start">16dp</dimen>	483 <dimen name="search_activity_location_bar_margin_start">16dp</dimen>

482 <dimen name="search_activity_location_bar_margin_end">8dp</dimen>	484 <dimen name="search_activity_location_bar_margin_end">8dp</dimen>

483 </resources>	485 </resources>

OLD	NEW