Don't hide profile statistics counters with zero results

Don't hide profile statistics counters with zero results

Currently the profile statistics counters are hidden if all of them
returned zero. This leads to an unstable, flickering UI. This Cl
changes them to always be visible to avoid this issue.

BUG=735873
Review-Url: https://codereview.chromium.org/2956873002
Cr-Commit-Position: refs/heads/master@{#483010}
Committed: https://chromium.googlesource.com/chromium/src/+/029879a344b8766661b7ce935a6431e5b3922b95

[dullweber, 2017-06-27 08:56:17]

dullweber@chromium.org changed reviewers:
+ xiyuan@chromium.org

[dullweber, 2017-06-27 08:56:18]

Hi, 
I received a bug report, that hiding the stat counters leads to flickering. I
also think that it is a useful information to show that a user has no data that
is going to be lost, so I removed the code this hides the counters if the result
is zero.

[dullweber, 2017-06-27 08:56:38]

Description was changed from

==========
Don't hide profile statistics counters with zero results

Currently the profile statistics counters are hidden if all them
returned zero. This leads to an unstable, flickering UI. This Cl
changes them to always be visible to avoid this issue.

BUG=735873
==========

to

==========
Don't hide profile statistics counters with zero results

Currently the profile statistics counters are hidden if all of them
returned zero. This leads to an unstable, flickering UI. This Cl
changes them to always be visible to avoid this issue.

BUG=735873
==========

[xiyuan, 2017-06-27 17:33:33]

https://codereview.chromium.org/2956873002/diff/20001/ui/login/account_picker...
File ui/login/account_picker/md_user_pod_row.js (right):

https://codereview.chromium.org/2956873002/diff/20001/ui/login/account_picker...
ui/login/account_picker/md_user_pod_row.js:2629:
this.classList.toggle('has-no-stats',
Should we remove this too ?

[dullweber, 2017-06-28 09:39:44]

https://codereview.chromium.org/2956873002/diff/20001/ui/login/account_picker...
File ui/login/account_picker/md_user_pod_row.js (right):

https://codereview.chromium.org/2956873002/diff/20001/ui/login/account_picker...
ui/login/account_picker/md_user_pod_row.js:2629:
this.classList.toggle('has-no-stats',
On 2017/06/27 17:33:33, xiyuan wrote:
> Should we remove this too ?

yes, we can probably remove has-no-stats completely. I changed the ProfileStats
to load the profile if required, so there is no case of not having stats
available anymore.

[xiyuan, 2017-06-28 15:40:21]

lgtm

Thanks.

[dullweber, 2017-06-28 15:43:10]

The CQ bit was checked by dullweber@chromium.org

[commit-bot: I haz the power, 2017-06-28 15:43:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 16:01:47]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498664590317980,
"parent_rev": "2b1ce04ab6f289c6a777426daebf677ddee089bf", "commit_rev":
"029879a344b8766661b7ce935a6431e5b3922b95"}

[commit-bot: I haz the power, 2017-06-28 16:02:04]

Description was changed from

==========
Don't hide profile statistics counters with zero results

Currently the profile statistics counters are hidden if all of them
returned zero. This leads to an unstable, flickering UI. This Cl
changes them to always be visible to avoid this issue.

BUG=735873
==========

to

==========
Don't hide profile statistics counters with zero results

Currently the profile statistics counters are hidden if all of them
returned zero. This leads to an unstable, flickering UI. This Cl
changes them to always be visible to avoid this issue.

BUG=735873

Review-Url: https://codereview.chromium.org/2956873002
Cr-Commit-Position: refs/heads/master@{#483010}
Committed:
https://chromium.googlesource.com/chromium/src/+/029879a344b8766661b7ce935a64...
==========

[commit-bot: I haz the power, 2017-06-28 16:02:05]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/029879a344b8766661b7ce935a64...