Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2956843002: [turbofan] Replace uninitialized JSCall nodes with SOFT deopt. (Closed)

Created:
3 years, 5 months ago by Benedikt Meurer
Modified:
3 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Replace uninitialized JSCall nodes with SOFT deopt. Uninitialized property accesses are replaced with SOFT deopts in TurboFan, but uninitialized JSCall nodes are not, and instead they just stick around and are also not being inlined because the heurstic in TurboFan doesn't consider those candidates since their call frequency is below the threshold. This unifies the behavior and also replaces uninitialized calls with SOFT deopts, addressing some inconsistency in optimization behavior as discovered by Brian White of Node for example here: https://twitter.com/mscdexdotexe/status/879005026202640385 R=jarin@chromium.org BUG=v8:4551, v8:5267 Review-Url: https://codereview.chromium.org/2956843002 Cr-Commit-Position: refs/heads/master@{#46231} Committed: https://chromium.googlesource.com/v8/v8/+/4ea4e7294e242583a7ec31b9a7e4f0101512e3b3

Patch Set 1 #

Patch Set 2 : Several improvements. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -26 lines) Patch
M src/compiler/bytecode-graph-builder.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 2 chunks +30 lines, -4 lines 0 comments Download
M src/compiler/js-call-reducer.h View 1 2 chunks +8 lines, -1 line 0 comments Download
M src/compiler/js-call-reducer.cc View 1 1 chunk +16 lines, -21 lines 0 comments Download
M src/compiler/js-type-hint-lowering.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/js-type-hint-lowering.cc View 1 1 chunk +16 lines, -0 lines 0 comments Download
M src/compiler/pipeline.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-unwinding-info.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 24 (16 generated)
Benedikt Meurer
3 years, 5 months ago (2017-06-26 09:49:03 UTC) #1
Jarin
lgtm
3 years, 5 months ago (2017-06-26 10:22:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2956843002/1
3 years, 5 months ago (2017-06-26 10:22:53 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng/builds/7994) v8_linux_verify_csa_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
3 years, 5 months ago (2017-06-26 12:06:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2956843002/1
3 years, 5 months ago (2017-06-26 17:31:49 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_ng/builds/8162) v8_linux64_verify_csa_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
3 years, 5 months ago (2017-06-26 17:44:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2956843002/20001
3 years, 5 months ago (2017-06-27 03:55:49 UTC) #21
commit-bot: I haz the power
3 years, 5 months ago (2017-06-27 03:57:22 UTC) #24
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/4ea4e7294e242583a7ec31b9a7e4f010151...

Powered by Google App Engine
This is Rietveld 408576698