Add GURL::HostNoBracketsPiece()

Add GURL::HostNoBracketsPiece()

In several places GURL::HostNoBrackets() is used as an argument to a
function that only requires a StringPiece. To avoid this unnecessary
string copy, add a HostNoBracketsPiece() variant in line with the
existing host_piece() variant.

This CL also changes calls to HostNoBrackets() to HostNoBracketsPiece()
where it is simple and useful.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2956643002
Cr-Commit-Position: refs/heads/master@{#483962}
Committed: https://chromium.googlesource.com/chromium/src/+/1c0de2ff74a1874e1fcfc12925694e8fd39af261

[Adam Rice, 2017-06-23 14:00:29]

Description was changed from

==========
Add GURL::HostNoBracketsPiece()

In several places GURL::HostNoBrackets() is used as an argument to a
function that only requires a StringPiece. To avoid this unnecessary
string copy, add a HostNoBracketsPiece() variant in line with the
existing host_piece() variant.

This CL also changes calls to HostNoBrackets() to HostNoBracketsPiece()
where it is simple and useful.

BUG=
==========

to

==========
Add GURL::HostNoBracketsPiece()

In several places GURL::HostNoBrackets() is used as an argument to a
function that only requires a StringPiece. To avoid this unnecessary
string copy, add a HostNoBracketsPiece() variant in line with the
existing host_piece() variant.

This CL also changes calls to HostNoBrackets() to HostNoBracketsPiece()
where it is simple and useful.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Adam Rice, 2017-06-23 14:01:12]

The CQ bit was checked by ricea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-23 14:01:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 17:24:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-23 17:24:05]

Dry run: This issue passed the CQ dry run.

[Adam Rice, 2017-06-26 08:33:08]

ricea@chromium.org changed reviewers:
+ brettw@chromium.org

[Adam Rice, 2017-06-26 08:33:09]

+brettw for //url.

[brettw, 2017-06-30 19:33:14]

lgtm

https://codereview.chromium.org/2956643002/diff/1/url/gurl_unittest.cc
File url/gurl_unittest.cc (right):

https://codereview.chromium.org/2956643002/diff/1/url/gurl_unittest.cc#newcod...
url/gurl_unittest.cc:566: class GURLHostTest : public ::testing::Test {
This is a lot of hard-to-read complexity, when I think we could just add a third
line in the for loop in HostNoBrackets to check that the host piece also
matches. Can you do that instead?

[Adam Rice, 2017-07-03 04:51:51]

https://codereview.chromium.org/2956643002/diff/1/url/gurl_unittest.cc
File url/gurl_unittest.cc (right):

https://codereview.chromium.org/2956643002/diff/1/url/gurl_unittest.cc#newcod...
url/gurl_unittest.cc:566: class GURLHostTest : public ::testing::Test {
On 2017/06/30 19:33:14, brettw wrote:
> This is a lot of hard-to-read complexity, when I think we could just add a
third
> line in the for loop in HostNoBrackets to check that the host piece also
> matches. Can you do that instead?

Thank you! I was so fixated on the type difference I couldn't see the simple way
of doing it.

[Adam Rice, 2017-07-03 05:29:51]

The CQ bit was checked by ricea@chromium.org

[Adam Rice, 2017-07-03 05:29:52]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2956643002/#ps20001
(title: "Simplify test")

[commit-bot: I haz the power, 2017-07-03 05:30:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-03 07:15:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-03 07:15:53]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Adam Rice, 2017-07-03 07:35:07]

The CQ bit was checked by ricea@chromium.org

[commit-bot: I haz the power, 2017-07-03 07:35:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-03 08:21:46]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1499067307478270,
"parent_rev": "55d6aa255db39bf45faa1c5138c10074854c1897", "commit_rev":
"1c0de2ff74a1874e1fcfc12925694e8fd39af261"}

[commit-bot: I haz the power, 2017-07-03 08:22:00]

Description was changed from

==========
Add GURL::HostNoBracketsPiece()

In several places GURL::HostNoBrackets() is used as an argument to a
function that only requires a StringPiece. To avoid this unnecessary
string copy, add a HostNoBracketsPiece() variant in line with the
existing host_piece() variant.

This CL also changes calls to HostNoBrackets() to HostNoBracketsPiece()
where it is simple and useful.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Add GURL::HostNoBracketsPiece()

In several places GURL::HostNoBrackets() is used as an argument to a
function that only requires a StringPiece. To avoid this unnecessary
string copy, add a HostNoBracketsPiece() variant in line with the
existing host_piece() variant.

This CL also changes calls to HostNoBrackets() to HostNoBracketsPiece()
where it is simple and useful.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2956643002
Cr-Commit-Position: refs/heads/master@{#483962}
Committed:
https://chromium.googlesource.com/chromium/src/+/1c0de2ff74a1874e1fcfc1292569...
==========

[commit-bot: I haz the power, 2017-07-03 08:22:01]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1c0de2ff74a1874e1fcfc1292569...

[Adam Rice, 2017-07-03 16:00:58]

Patchset #3 (id:40001) has been deleted