Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 2956593003: Revert of Move navigation-induced hiding of form-validation-bubble to the browser process. (Closed)

Created:
3 years, 6 months ago by dcheng
Modified:
3 years, 6 months ago
CC:
chromium-reviews, sof, creis+watch_chromium.org, eae+blinkwatch, nasko+codewatch_chromium.org, jam, blink-reviews-dom_chromium.org, dglazkov+blink, darin-cc_chromium.org, blink-reviews, blink-reviews-html_chromium.org, rwlbuis, Evan Stade
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move navigation-induced hiding of form-validation-bubble to the browser process. (patchset #2 id:20001 of https://codereview.chromium.org/2949593003/ ) Reason for revert: Causing failures on WebKit Linux Trusty Leak. ({"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,62],"numberOfLiveResources":[0,2],"numberOfLiveSuspendableObjects":[2,3]}) Original issue's description: > Move navigation-induced hiding of form-validation-bubble to the browser process. > > Moving hiding of the form validation bubble to the browser process has > the following benefits: > - It allows simplifying/removing code from Blink (in particular it > allows removing some of the code added in r459701). > - It makes the hiding immune against compromised renderers. > - It makes the hiding work even if ViewHostMsg_HideValidationMessage IPC > gets filtered out (i.e. see CanSendWhileSwappedOut method in > content::SwappedOutMessages). This in turn will allow relanding > of r479538. > > BUG=733940 > TEST=Manually verified that bugs 733940, 704560, 673163 are still fixed. > > Review-Url: https://codereview.chromium.org/2949593003 > Cr-Commit-Position: refs/heads/master@{#481681} > Committed: https://chromium.googlesource.com/chromium/src/+/15399f887a0e8498253dc4496446eee83158e96a TBR=tkent@chromium.org,alexmos@chromium.org,estade@chromium.org,avi@chromium.org,lukasza@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=733940 Review-Url: https://codereview.chromium.org/2956593003 Cr-Commit-Position: refs/heads/master@{#481827} Committed: https://chromium.googlesource.com/chromium/src/+/77083a5a889ea093f3343a68c543359c6a16f206

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -76 lines) Patch
M content/browser/web_contents/web_contents_impl.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_browsertest.cc View 1 chunk +0 lines, -74 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentTest.cpp View 3 chunks +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormControlElementTest.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/ValidationMessageClient.h View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/ValidationMessageClientImpl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/ValidationMessageClientImpl.cpp View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
dcheng
Created Revert of Move navigation-induced hiding of form-validation-bubble to the browser process.
3 years, 6 months ago (2017-06-23 08:34:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2956593003/1
3 years, 6 months ago (2017-06-23 08:34:22 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 08:35:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/77083a5a889ea093f3343a68c543...

Powered by Google App Engine
This is Rietveld 408576698