Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2956563002: cc: Fix DCHECK failure for pending tree raster duration timer. (Closed)

Created:
3 years, 6 months ago by Khushal
Modified:
3 years, 6 months ago
Reviewers:
danakj, sunnyps
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Fix DCHECK failure for pending tree raster duration timer. We currently assume that activation will always be preceded by being notified that the tree is ready to be activated but that's not necessarily true. Fix that. BUG=736193 R=sunnyps@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2956563002 Cr-Commit-Position: refs/heads/master@{#481980} Committed: https://chromium.googlesource.com/chromium/src/+/55116d34017a084746e6829576e5716d5586d084

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M cc/trees/layer_tree_host_impl.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Khushal
3 years, 6 months ago (2017-06-23 03:56:54 UTC) #2
Khushal
3 years, 6 months ago (2017-06-23 17:45:28 UTC) #4
Khushal
Would it be possible to have a quick review? This is causing flakes on trybots. ...
3 years, 6 months ago (2017-06-23 17:46:08 UTC) #5
danakj
LGTM
3 years, 6 months ago (2017-06-23 17:48:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2956563002/1
3 years, 6 months ago (2017-06-23 17:49:21 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/55116d34017a084746e6829576e5716d5586d084
3 years, 6 months ago (2017-06-23 19:01:22 UTC) #11
sunnyps
3 years, 6 months ago (2017-06-23 19:02:32 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698