Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 2956543003: auth: Fix very unlikely race condition (sort of) when refreshing token. (Closed)

Created:
3 years, 6 months ago by Vadim Sh.
Modified:
3 years, 6 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

auth: Fix very unlikely race condition (sort of) when refreshing token. Also dedup some code. R=iannucci@chromium.org BUG= Review-Url: https://codereview.chromium.org/2956543003 Committed: https://github.com/luci/luci-go/commit/34a3b4f2ab59c6082472e3d880843ba11d3c7243

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -24 lines) Patch
M common/auth/auth.go View 3 chunks +13 lines, -24 lines 2 comments Download

Messages

Total messages: 8 (3 generated)
Vadim Sh.
PTAL I hope my explanation makes sense.
3 years, 6 months ago (2017-06-22 23:56:09 UTC) #1
iannucci
lgtm https://codereview.chromium.org/2956543003/diff/1/common/auth/auth.go File common/auth/auth.go (right): https://codereview.chromium.org/2956543003/diff/1/common/auth/auth.go#newcode577 common/auth/auth.go:577: tok, err = a.refreshToken(tok, lifetime+5*time.Second) would it make ...
3 years, 6 months ago (2017-06-23 00:06:18 UTC) #2
Vadim Sh.
https://codereview.chromium.org/2956543003/diff/1/common/auth/auth.go File common/auth/auth.go (right): https://codereview.chromium.org/2956543003/diff/1/common/auth/auth.go#newcode577 common/auth/auth.go:577: tok, err = a.refreshToken(tok, lifetime+5*time.Second) On 2017/06/23 00:06:18, iannucci ...
3 years, 6 months ago (2017-06-23 00:11:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2956543003/1
3 years, 6 months ago (2017-06-23 00:41:02 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 00:53:45 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/34a3b4f2ab59c6082472e3d880843ba11d3c7243

Powered by Google App Engine
This is Rietveld 408576698