Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 2956513002: [Autofill] Adding a prefix to the list of family names. (Closed)

Created:
3 years, 6 months ago by Parastoo
Modified:
3 years, 6 months ago
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding a prefix to the list of family names, because otherwise some names would not be parsed correctly. BUG=687727 Review-Url: https://codereview.chromium.org/2956513002 Cr-Commit-Position: refs/heads/master@{#481901} Committed: https://chromium.googlesource.com/chromium/src/+/8bacc33c910f8c9d12f403b3f1dbdc9231ce6c95

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M components/autofill/core/browser/autofill_data_util.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Parastoo
3 years, 6 months ago (2017-06-22 20:02:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2956513002/1
3 years, 6 months ago (2017-06-22 20:03:45 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 6 months ago (2017-06-22 20:03:47 UTC) #7
Roger McFarlane (Chromium)
lgtm
3 years, 6 months ago (2017-06-22 21:04:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2956513002/1
3 years, 6 months ago (2017-06-23 15:44:27 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 15:48:49 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8bacc33c910f8c9d12f403b3f1db...

Powered by Google App Engine
This is Rietveld 408576698