Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2956503002:
Adding a previews blacklist transtion entry to fieldtrial list (Closed)
DescriptionAdding a previews blacklist transtion entry to fieldtrial list
This adds the approrpriate experiment names to the fieldtrail testing
congig file.
BUG=736458
Review-Url: https://codereview.chromium.org/2956503002
Cr-Commit-Position: refs/heads/master@{#482018}
Committed: https://chromium.googlesource.com/chromium/src/+/0249c2f8fe03137a35dcca5c4e5c6e2d3d197e43
Patch Set 1 #
Total comments: 3
Patch Set 2 : comments #Messages
Total messages: 21 (14 generated)
The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
ryansturm@chromium.org changed reviewers: + rkaplow@chromium.org, tbansal@chromium.org
rkaplow, tbansal: PTAL, thanks!
https://codereview.chromium.org/2956503002/diff/1/testing/variations/fieldtri... File testing/variations/fieldtrial_testing_config.json (right): https://codereview.chromium.org/2956503002/diff/1/testing/variations/fieldtri... testing/variations/fieldtrial_testing_config.json:612: "name": "Control" IIUC, there is no need to add "Control" and "Disabled" since that's just the existing behavior.
lgtm https://codereview.chromium.org/2956503002/diff/1/testing/variations/fieldtri... File testing/variations/fieldtrial_testing_config.json (right): https://codereview.chromium.org/2956503002/diff/1/testing/variations/fieldtri... testing/variations/fieldtrial_testing_config.json:612: "name": "Control" On 2017/06/23 17:18:02, tbansal1 wrote: > IIUC, there is no need to add "Control" and "Disabled" since that's just the > existing behavior. also only the first one listed gets tested. So you should omit these two. Also it looks like you're not using go/featureapi - it's recommended for all new trials.
The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2956503002/diff/1/testing/variations/fieldtri... File testing/variations/fieldtrial_testing_config.json (right): https://codereview.chromium.org/2956503002/diff/1/testing/variations/fieldtri... testing/variations/fieldtrial_testing_config.json:612: "name": "Control" On 2017/06/23 19:26:20, rkaplow wrote: > On 2017/06/23 17:18:02, tbansal1 wrote: > > IIUC, there is no need to add "Control" and "Disabled" since that's just the > > existing behavior. > > also only the first one listed gets tested. So you should omit these two. > > Also it looks like you're not using go/featureapi - it's recommended for all new > trials. Done. Definitely will use feature api in the future. Thanks!
lgtm % missing bug number in the CL description.
Description was changed from ========== Adding a previews blacklist transtion entry to fieldtrial list This adds the approrpriate experiment names to the fieldtrail testing congig file. BUG= ========== to ========== Adding a previews blacklist transtion entry to fieldtrial list This adds the approrpriate experiment names to the fieldtrail testing congig file. BUG=736458 ==========
The CQ bit was unchecked by ryansturm@chromium.org
The CQ bit was checked by ryansturm@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rkaplow@chromium.org Link to the patchset: https://codereview.chromium.org/2956503002/#ps20001 (title: "comments")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498246405439350,
"parent_rev": "07a754c70339bd975c433dfe344f003eaeaa8cc3", "commit_rev":
"0249c2f8fe03137a35dcca5c4e5c6e2d3d197e43"}
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498246405439350,
"parent_rev": "07a754c70339bd975c433dfe344f003eaeaa8cc3", "commit_rev":
"0249c2f8fe03137a35dcca5c4e5c6e2d3d197e43"}
Message was sent while issue was closed.
Description was changed from ========== Adding a previews blacklist transtion entry to fieldtrial list This adds the approrpriate experiment names to the fieldtrail testing congig file. BUG=736458 ========== to ========== Adding a previews blacklist transtion entry to fieldtrial list This adds the approrpriate experiment names to the fieldtrail testing congig file. BUG=736458 Review-Url: https://codereview.chromium.org/2956503002 Cr-Commit-Position: refs/heads/master@{#482018} Committed: https://chromium.googlesource.com/chromium/src/+/0249c2f8fe03137a35dcca5c4e5c... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/0249c2f8fe03137a35dcca5c4e5c... |
