Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1379)

Issue 2956473002: [WebPayments] Order Summary a11y (Closed)

Created:
3 years, 6 months ago by tmartino
Modified:
3 years, 6 months ago
Reviewers:
anthonyvd
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

This CL corrects issues with screen reader accessibility on the order summary screen. Specifically: - Does not read the "preview" text (e.g., "123 Fake St. and 1 other...") as it is confusingly similar to the selected state. - Adds accessible content when a payment method has been selected. BUG=733684 Review-Url: https://codereview.chromium.org/2956473002 Cr-Commit-Position: refs/heads/master@{#481907} Committed: https://chromium.googlesource.com/chromium/src/+/69ad872ecf7a6d4bfebf69a4c18544146ef85433

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -14 lines) Patch
M chrome/browser/ui/views/payments/payment_sheet_view_controller.cc View 4 chunks +10 lines, -14 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
tmartino
3 years, 6 months ago (2017-06-22 19:37:04 UTC) #5
anthonyvd
lgtm
3 years, 6 months ago (2017-06-23 14:55:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2956473002/1
3 years, 6 months ago (2017-06-23 15:55:04 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 15:59:03 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/69ad872ecf7a6d4bfebf69a4c185...

Powered by Google App Engine
This is Rietveld 408576698