Clean up DocumentMarkerController::MarkersFor()

Clean up DocumentMarkerController::MarkersFor()

I'm cleaning up two things here:

- Adding a check to PossiblyHasMarkers() (probably doesn't save us very much
  time, but we can at least avoid a hashmap lookup in the "no markers" case)
- Fixing the loop to just loop over the passed-in set of MarkerTypes vs. looping
  over all types and skipping over some of them

BUG=707867
Review-Url: https://codereview.chromium.org/2956453002
Cr-Commit-Position: refs/heads/master@{#485038}
Committed: https://chromium.googlesource.com/chromium/src/+/f37e7fd6eb873016a023acc58a121161128aeabd

[rlanday, 2017-06-22 18:11:27]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[rlanday, 2017-06-22 18:11:38]

rlanday@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yosin@chromium.org

[commit-bot: I haz the power, 2017-06-22 18:11:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-06-22 18:13:09]

lgtm

Good catch!

[commit-bot: I haz the power, 2017-06-22 21:01:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 21:01:34]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-06-23 06:15:59]

lgtm

Good catch!

[rlanday, 2017-07-07 18:49:42]

The CQ bit was checked by rlanday@chromium.org

[commit-bot: I haz the power, 2017-07-07 18:50:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-07 20:52:37]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1499453382656020, "parent_rev":
"54c314a569da0a5f5c61436a36a29969fbfe2871", "commit_rev":
"f37e7fd6eb873016a023acc58a121161128aeabd"}

[commit-bot: I haz the power, 2017-07-07 20:52:50]

Description was changed from

==========
Clean up DocumentMarkerController::MarkersFor()

I'm cleaning up two things here:

- Adding a check to PossiblyHasMarkers() (probably doesn't save us very much
  time, but we can at least avoid a hashmap lookup in the "no markers" case)
- Fixing the loop to just loop over the passed-in set of MarkerTypes vs. looping
  over all types and skipping over some of them

BUG=707867
==========

to

==========
Clean up DocumentMarkerController::MarkersFor()

I'm cleaning up two things here:

- Adding a check to PossiblyHasMarkers() (probably doesn't save us very much
  time, but we can at least avoid a hashmap lookup in the "no markers" case)
- Fixing the loop to just loop over the passed-in set of MarkerTypes vs. looping
  over all types and skipping over some of them

BUG=707867

Review-Url: https://codereview.chromium.org/2956453002
Cr-Commit-Position: refs/heads/master@{#485038}
Committed:
https://chromium.googlesource.com/chromium/src/+/f37e7fd6eb873016a023acc58a12...
==========

[commit-bot: I haz the power, 2017-07-07 20:52:51]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f37e7fd6eb873016a023acc58a12...