Fixup icon for new lock screen note action item

Fixup icon for new lock screen note action item

* Use correctly sized icon - 16 dip vs 20 dip
* Remove uneeded NewNoteActionView wrapper around the icon, and
  instead use ImageView directly.

BUG=737338, 725130
Review-Url: https://codereview.chromium.org/2956383002
Cr-Commit-Position: refs/heads/master@{#483189}
Committed: https://chromium.googlesource.com/chromium/src/+/fb97d866ca2ba77f826975a13524eae76839c37a

[tbarzic, 2017-06-28 20:15:09]

tbarzic@chromium.org changed reviewers:
+ tdanderson@chromium.org

[tdanderson, 2017-06-28 20:45:24]

LGTM with one nit. Thanks again for coming back to this.

https://codereview.chromium.org/2956383002/diff/1/ash/system/lock_screen_acti...
File ash/system/lock_screen_action/lock_screen_action_tray.cc (right):

https://codereview.chromium.org/2956383002/diff/1/ash/system/lock_screen_acti...
ash/system/lock_screen_action/lock_screen_action_tray.cc:32:
kTrayActionNewLockScreenNoteIcon, kTrayIconSize, kShelfIconColor));
nit: you can omit the kTrayIconSize argument since the size is already specified
at the top of the .1x.icon file

[tbarzic, 2017-06-28 21:00:07]

https://codereview.chromium.org/2956383002/diff/1/ash/system/lock_screen_acti...
File ash/system/lock_screen_action/lock_screen_action_tray.cc (right):

https://codereview.chromium.org/2956383002/diff/1/ash/system/lock_screen_acti...
ash/system/lock_screen_action/lock_screen_action_tray.cc:32:
kTrayActionNewLockScreenNoteIcon, kTrayIconSize, kShelfIconColor));
On 2017/06/28 20:45:23, tdanderson wrote:
> nit: you can omit the kTrayIconSize argument since the size is already
specified
> at the top of the .1x.icon file

Done.

[tbarzic, 2017-06-28 21:00:11]

The CQ bit was checked by tbarzic@chromium.org

[tbarzic, 2017-06-28 21:00:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdanderson@chromium.org
Link to the patchset: https://codereview.chromium.org/2956383002/#ps20001
(title: ".")

[commit-bot: I haz the power, 2017-06-28 21:00:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 23:31:24]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498683611839470,
"parent_rev": "6143e645a26b391ece7c82c4c4b76270eb674b4a", "commit_rev":
"fb97d866ca2ba77f826975a13524eae76839c37a"}

[commit-bot: I haz the power, 2017-06-28 23:31:40]

Description was changed from

==========
Fixup icon for new lock screen note action item

* Use correctly sized icon - 16 dip vs 20 dip
* Remove uneeded NewNoteActionView wrapper around the icon, and
  instead use ImageView directly.

BUG=737338,725130
==========

to

==========
Fixup icon for new lock screen note action item

* Use correctly sized icon - 16 dip vs 20 dip
* Remove uneeded NewNoteActionView wrapper around the icon, and
  instead use ImageView directly.

BUG=737338,725130

Review-Url: https://codereview.chromium.org/2956383002
Cr-Commit-Position: refs/heads/master@{#483189}
Committed:
https://chromium.googlesource.com/chromium/src/+/fb97d866ca2ba77f826975a13524...
==========

[commit-bot: I haz the power, 2017-06-28 23:31:41]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fb97d866ca2ba77f826975a13524...