Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2956373003: Add Click to Open PDF Placeholder feature (Closed)

Created:
3 years, 5 months ago by amberwon
Modified:
3 years, 5 months ago
Reviewers:
tommycli
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Click to Open PDF Placeholder feature Create this feature and have it disabled while it's under development. BUG=737787 Review-Url: https://codereview.chromium.org/2956373003 Cr-Commit-Position: refs/heads/master@{#483403} Committed: https://chromium.googlesource.com/chromium/src/+/3da52ff61da23b01c1a87fb8d253cd1dd585e9ac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/common/chrome_features.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/chrome_features.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
amberwon
3 years, 5 months ago (2017-06-28 23:41:48 UTC) #4
tommycli
lgtm with one request: beef up the commit description
3 years, 5 months ago (2017-06-29 00:30:41 UTC) #5
amberwon
On 2017/06/29 00:30:41, tommycli wrote: > lgtm with one request: beef up the commit description ...
3 years, 5 months ago (2017-06-29 17:09:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2956373003/1
3 years, 5 months ago (2017-06-29 17:09:39 UTC) #11
commit-bot: I haz the power
3 years, 5 months ago (2017-06-29 17:13:17 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3da52ff61da23b01c1a87fb8d253...

Powered by Google App Engine
This is Rietveld 408576698