Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Issue 2956343003: [pinpoint] Post bug comments when a job starts and completes. (Closed)

Created:
3 years, 5 months ago by dtu
Modified:
3 years, 5 months ago
Reviewers:
perezju, shatch, sullivan
CC:
catapult-reviews_chromium.org, perf-dashboard-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -4 lines) Patch
M dashboard/dashboard/pinpoint/handlers/jobs_test.py View 1 chunk +2 lines, -1 line 0 comments Download
M dashboard/dashboard/pinpoint/handlers/new.py View 2 chunks +3 lines, -1 line 0 comments Download
M dashboard/dashboard/pinpoint/models/job.py View 5 chunks +30 lines, -2 lines 1 comment Download

Messages

Total messages: 9 (4 generated)
dtu
3 years, 5 months ago (2017-06-28 23:43:54 UTC) #2
perezju
lgtm https://codereview.chromium.org/2956343003/diff/1/dashboard/dashboard/pinpoint/models/job.py File dashboard/dashboard/pinpoint/models/job.py (right): https://codereview.chromium.org/2956343003/diff/1/dashboard/dashboard/pinpoint/models/job.py#newcode72 dashboard/dashboard/pinpoint/models/job.py:72: bug_id = ndb.IntegerProperty() Note that, probably, we would ...
3 years, 5 months ago (2017-06-29 09:03:30 UTC) #3
shatch
lgtm
3 years, 5 months ago (2017-06-29 15:11:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2956343003/1
3 years, 5 months ago (2017-06-30 20:35:53 UTC) #6
commit-bot: I haz the power
3 years, 5 months ago (2017-06-30 21:01:11 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698