[Cronet] Include embedded test server AIDL in cronet_tests_java.jar

[Cronet] Include embedded test server AIDL in cronet_tests_java.jar

This was moved out of cronet_tests_java in r479841 causing testing
using cronet_tests_java.jar to fail.

BUG=683256
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2956293002
Cr-Commit-Position: refs/heads/master@{#483202}
Committed: https://chromium.googlesource.com/chromium/src/+/cbc07924907af3ac0157f3208c1ce1463e8bf888

[pauljensen, 2017-06-28 15:30:18]

Description was changed from

==========
[Cronet] Include embedded test server AIDL in cronet_tests_java.jar

This was moved out of cronet_tests_java in r479841 causing testing
using cronet_tests_java.jar to fail.

BUG=683256
==========

to

==========
[Cronet] Include embedded test server AIDL in cronet_tests_java.jar

This was moved out of cronet_tests_java in r479841 causing testing
using cronet_tests_java.jar to fail.

BUG=683256
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[pauljensen, 2017-06-28 15:39:58]

pauljensen@chromium.org changed reviewers:
+ mef@chromium.org

[pauljensen, 2017-06-28 15:39:59]

Misha, PTAL, thank you!

[mef, 2017-06-28 17:11:16]

On 2017/06/28 15:39:59, pauljensen wrote:
> Misha, PTAL, thank you!

Sorry for missing it, but I don't quite understand the failure, how is it caused
by https://chromium-review.googlesource.com/c/535833/ and how is it fixed. 
Do you have a link to broken tests?

[pauljensen, 2017-06-28 17:16:17]

On 2017/06/28 17:11:16, mef wrote:
> On 2017/06/28 15:39:59, pauljensen wrote:
> > Misha, PTAL, thank you!
> 
> Sorry for missing it, but I don't quite understand the failure, how is it
caused
> by https://chromium-review.googlesource.com/c/535833/ and how is it fixed. 
> Do you have a link to broken tests?

Without this fix when testing with just cronet_tests_java.jar we hit this error:
java.lang.NoClassDefFoundError: Failed resolution of:
Lorg/chromium/net/test/IEmbeddedTestServerImpl$Stub;
 	at
org.chromium.net.test.EmbeddedTestServer$1.onServiceConnected(EmbeddedTestServer.java:46)
This fixes it by including that class in cronet_tests_java.jar, and our tests
pass then.
Our chromium tests don't use cronet_tests_java, though perhaps they should.

[pauljensen, 2017-06-28 17:50:30]

EmbeddedTestServer comes from net_java_test_support.
EmbeddedTestServerImpl and embedded_test_server_aidl_java used to come from
net_java_test_support but now comes from net_java_test_support_provider.
net_java_test_support is a dep of cronet_tests_java but not
net_java_test_support_provider, which is new (added in r479841).

When testing with cronet_tests_java.jar, one also uses
ChromiumNetTestSupport.apk (//net/android:net_test_support_apk) which includes
EmbeddedTestServerImpl, but in a separate app/apk.
It appears EmbeddedTestServer (in cronet_tests_java.jar) needs
embedded_test_server_aidl_java to communicate with ChromiumNetTestSupport.apk; I
assume because it defines the AIDL interface used to control it.

[mef, 2017-06-28 21:56:12]

Thanks for explanation, lgtm

[pauljensen, 2017-06-28 21:59:06]

The CQ bit was checked by pauljensen@chromium.org

[commit-bot: I haz the power, 2017-06-28 22:00:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 23:44:59]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498687146589900, "parent_rev":
"e293efc74b2050a2eb73e5d17009a59a3d57dc51", "commit_rev":
"2cecead73e64ebe431229a8e253701fa7a7c3894"}

[commit-bot: I haz the power, 2017-06-28 23:45:21]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498687146589900, "parent_rev":
"575c78d71e1d4a3d878807bf4fbde337cff18f97", "commit_rev":
"cbc07924907af3ac0157f3208c1ce1463e8bf888"}

[commit-bot: I haz the power, 2017-06-28 23:45:34]

Description was changed from

==========
[Cronet] Include embedded test server AIDL in cronet_tests_java.jar

This was moved out of cronet_tests_java in r479841 causing testing
using cronet_tests_java.jar to fail.

BUG=683256
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
[Cronet] Include embedded test server AIDL in cronet_tests_java.jar

This was moved out of cronet_tests_java in r479841 causing testing
using cronet_tests_java.jar to fail.

BUG=683256
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2956293002
Cr-Commit-Position: refs/heads/master@{#483202}
Committed:
https://chromium.googlesource.com/chromium/src/+/cbc07924907af3ac0157f3208c1c...
==========

[commit-bot: I haz the power, 2017-06-28 23:45:35]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cbc07924907af3ac0157f3208c1c...