Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2956143002: Add UMA metrics for Bluetooth system daemon (Closed)

Created:
3 years, 5 months ago by mcchou
Modified:
3 years, 5 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UMA metrics for Bluetooth system daemon This adds the following histograms and corresponding enums definitions. [Histograms] - BlueZ.ReasonOfDisconnection - BlueZ.ResultOfAdvertisementRegistration - BlueZ.ResultOfConnection - BlueZ.ResultOfPairing - BlueZ.TimeLengthOfAdvertisement - BlueZ.TimeLengthOfDiscoverable - BlueZ.TimeLengthOfDiscovering - BlueZ.TimeLengthOfPairing - BlueZ.TimeLengthOfSetupConnection - BlueZ.TypeOfDiscovery - BlueZ.TypeOfFoundDevice [Enums] - BlueZReasonOfDisconnection - BlueZResultOfAdvertisementRegistration - BlueZResultOfConnection - BlueZResultOfPairing - BlueZTypeOfDiscovery - BlueZTypeOfFoundDevice BUG=chromium:724720 Review-Url: https://codereview.chromium.org/2956143002 Cr-Commit-Position: refs/heads/master@{#483175} Committed: https://chromium.googlesource.com/chromium/src/+/6c4da1390d590da133fa547a590edfbbcb292df4

Patch Set 1 #

Patch Set 2 : Add a link to where metrics are added in the commit message. #

Total comments: 1

Patch Set 3 : Add "Chrome OS specific" to the descriptions of histograms. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -1 line) Patch
M tools/metrics/histograms/enums.xml View 1 chunk +64 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +113 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
Miao
Please see https://chromium-review.googlesource.com/c/538910/ for metrics reference.
3 years, 5 months ago (2017-06-27 22:32:13 UTC) #2
Miao
3 years, 5 months ago (2017-06-27 23:15:43 UTC) #4
Alexei Svitkine (slow)
lgtm https://codereview.chromium.org/2956143002/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2956143002/diff/20001/tools/metrics/histograms/histograms.xml#newcode6519 tools/metrics/histograms/histograms.xml:6519: + of disconnection request. Mention that these are ...
3 years, 5 months ago (2017-06-28 16:58:43 UTC) #5
Miao
On 2017/06/28 16:58:43, Alexei Svitkine (slow) wrote: > lgtm > > https://codereview.chromium.org/2956143002/diff/20001/tools/metrics/histograms/histograms.xml > File tools/metrics/histograms/histograms.xml ...
3 years, 5 months ago (2017-06-28 17:22:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2956143002/40001
3 years, 5 months ago (2017-06-28 22:26:16 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/6c4da1390d590da133fa547a590edfbbcb292df4
3 years, 5 months ago (2017-06-28 22:30:32 UTC) #16
Takashi Toyoshima
3 years, 5 months ago (2017-06-29 18:31:31 UTC) #17
Message was sent while issue was closed.
QQ: did you see any presubmit warnings or errors on the histograms.xml?

Powered by Google App Engine
This is Rietveld 408576698