Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2956123002: [wpr-go] Match NegotiatedProtocol (Closed)

Created:
3 years, 5 months ago by xunjieli
Modified:
3 years, 5 months ago
Reviewers:
nednguyen, Tom Bergan
CC:
catapult-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[wpr-go] Match NegotiatedProtocol Use a tls.Config with NextProtos that match the protocol used by the original server. If Chrome negotiated h2, the replay server should also speak h2 when the resource is requested. If h2 is not used in recording mode, replay mode should default to http/1.1. BUG=catapult:#3674 Review-Url: https://codereview.chromium.org/2956123002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/b0300e32745103bd6cf8ed6c4e54e524c22c1392

Patch Set 1 : self #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -67 lines) Patch
M web_page_replay_go/src/webpagereplay/archive.go View 10 chunks +41 lines, -42 lines 0 comments Download
M web_page_replay_go/src/webpagereplay/certs.go View 4 chunks +39 lines, -24 lines 0 comments Download
M web_page_replay_go/src/webpagereplay/proxy.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (11 generated)
xunjieli
PTAL. Thank you.
3 years, 5 months ago (2017-06-27 20:00:46 UTC) #7
Tom Bergan
lgtm
3 years, 5 months ago (2017-06-27 21:37:02 UTC) #8
xunjieli
I will check in this now. Ned told me he is busy with OKR these ...
3 years, 5 months ago (2017-06-28 13:31:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2956123002/60001
3 years, 5 months ago (2017-06-28 13:31:27 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Linux Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Linux%20Tryserver/builds/8001)
3 years, 5 months ago (2017-06-28 14:32:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2956123002/60001
3 years, 5 months ago (2017-06-28 14:43:17 UTC) #15
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 14:57:41 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:60001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698