Issue 2956093002: Issue 29960. Both CommandLineOptions and AnalysisOptions must be equal to reuse the context.

Issue 2956093002: Issue 29960. Both CommandLineOptions and AnalysisOptions must be equal to reuse the context. (Closed)

Created:
3 years, 5 months ago by scheglov

Modified:
3 years, 5 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Issue 29960. Both CommandLineOptions and AnalysisOptions must be equal to reuse the context. Unfortunately this makes running shared tests about 30% slower, because we have to perform I/O while trying to find analysis_options.yaml files corresponding to the files to be analyzed. R=brianwilkerson@google.com BUG= https://github.com/dart-lang/sdk/issues/29960 Committed: https://github.com/dart-lang/sdk/commit/bc345836610725c629e0fc2007ad349e400ec272

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -7 lines)			Patch
	M	pkg/analyzer/lib/src/generated/engine.dart	View		1 chunk	+15 lines, -0 lines	0 comments	Download
	M	pkg/analyzer_cli/lib/src/driver.dart	View		4 chunks	+30 lines, -7 lines	0 comments	Download

Total messages: 6 (3 generated)

scheglov

3 years, 5 months ago (2017-06-27 16:33:09 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
bc345836610725c629e0fc2007ad349e400ec272 (presubmit successful).