Issue 29960. Both CommandLineOptions and AnalysisOptions must be equal to reuse the context.

pkg/analyzer_cli/lib/src/driver.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 import 'dart:io' as io;
 
 import 'package:analyzer/error/error.dart';
 import 'package:analyzer/file_system/file_system.dart' as file_system;
 import 'package:analyzer/file_system/file_system.dart';
@@ skipping 295 matching lines @@
                 dartSdkPath: options.dartSdkPath)
             .run();
       } else {
         return new BuildMode(resourceProvider, options, stats).analyze();
       }
     });
   }
 
   /// Determine whether the context created during a previous call to
   /// [_analyzeAll] can be re-used in order to analyze using [options].
-  bool _canContextBeReused(CommandLineOptions options) {
+  bool _canContextBeReused(
+      CommandLineOptions options, AnalysisOptionsImpl other) {
     // TODO(paulberry): add a command-line option that disables context re-use.
     if (_context == null) {
       return false;
     }
+
+    // Check command line options.
     if (options.packageRootPath != _previousOptions.packageRootPath) {
       return false;
     }
     if (options.packageConfigPath != _previousOptions.packageConfigPath) {
       return false;
     }
     if (!_equalMaps(
         options.definedVariables, _previousOptions.definedVariables)) {
       return false;
     }
@@ skipping 30 matching lines @@
     if (options.enableSuperMixins != _previousOptions.enableSuperMixins) {
       return false;
     }
     if (!_equalLists(
         options.buildSummaryInputs, _previousOptions.buildSummaryInputs)) {
       return false;
     }
     if (options.disableCacheFlushing != _previousOptions.disableCacheFlushing) {
       return false;
     }
+
+    // Check analysis options.
+    var c = _context.analysisOptions;
+    if (!(other.enableAssertInitializer == c.enableAssertInitializer &&
+        other.enableStrictCallChecks == c.enableStrictCallChecks &&
+        other.enableLazyAssignmentOperators ==
+            c.enableLazyAssignmentOperators &&
+        other.enableSuperMixins == c.enableSuperMixins &&
+        other.enableTiming == c.enableTiming &&
+        other.generateImplicitErrors == c.generateImplicitErrors &&
+        other.generateSdkErrors == c.generateSdkErrors &&
+        other.hint == c.hint &&
+        other.lint == c.lint &&
+        AnalysisOptionsImpl.compareLints(other.lintRules, c.lintRules) &&
+        other.preserveComments == c.preserveComments &&
+        other.strongMode == c.strongMode)) {
+      return false;
+    }
+
     return true;
   }
 
   /// Decide on the appropriate policy for which files need to be fully parsed
   /// and which files need to be diet parsed, based on [options], and return an
   /// [AnalyzeFunctionBodiesPredicate] that implements this policy.
   AnalyzeFunctionBodiesPredicate _chooseDietParsingPolicy(
       CommandLineOptions options) {
     if (options.shouldBatch) {
       // As analyzer is currently implemented, once a file has been diet
@@ skipping 157 matching lines @@
     Uri uri = _context.sourceFactory.restoreUri(source);
     if (uri == null) {
       return source;
     }
     return new FileSource(sourceFile, uri);
   }
 
   /// Create an analysis context that is prepared to analyze sources according
   /// to the given [options], and store it in [_context].
   void _createAnalysisContext(CommandLineOptions options) {
-    if (_canContextBeReused(options)) {
+    AnalysisOptionsImpl analysisOptions =
+        createAnalysisOptionsForCommandLineOptions(resourceProvider, options);
+    analysisOptions.analyzeFunctionBodiesPredicate =
+        _chooseDietParsingPolicy(options);
+
+    if (_canContextBeReused(options, analysisOptions)) {
       return;
     }
+
     _previousOptions = options;
 
     // Save stats from previous context before clobbering it.
     if (_context != null) {
       _analyzedFileCount += _context.sources.length;
     }
 
     // Find package info.
     _PackageInfo packageInfo = _findPackages(options);
 
     // Process embedders.
     Map<file_system.Folder, YamlMap> embedderMap =
         new EmbedderYamlLocator(packageInfo.packageMap).embedderYamls;
 
     // Scan for SDK extenders.
     bool hasSdkExt = _hasSdkExt(packageInfo.packageMap?.values);
 
     // No summaries in the presence of embedders or extenders.
     bool useSummaries = embedderMap.isEmpty && !hasSdkExt;
 
     if (!useSummaries && options.buildSummaryInputs.isNotEmpty) {
       throw new _DriverError(
           'Summaries are not yet supported when using Flutter.');
     }
 
     // Read any input summaries.
     SummaryDataStore summaryDataStore = new SummaryDataStore(
         useSummaries ? options.buildSummaryInputs : <String>[]);
 
-    AnalysisOptionsImpl analysisOptions =
-        createAnalysisOptionsForCommandLineOptions(resourceProvider, options);
-    analysisOptions.analyzeFunctionBodiesPredicate =
-        _chooseDietParsingPolicy(options);
-
     // Once options and embedders are processed, setup the SDK.
     _setupSdk(options, useSummaries, analysisOptions);
 
     PackageBundle sdkBundle = sdk.getLinkedBundle();
     if (sdkBundle != null) {
       summaryDataStore.addBundle(null, sdkBundle);
     }
 
     // Choose a package resolution policy and a diet parsing policy based on
     // the command-line options.
@@ skipping 294 matching lines @@
     for (var package in packages) {
       var packageName = path.basename(package.path);
       var realPath = package.resolveSymbolicLinksSync();
       result[packageName] = [
         PhysicalResourceProvider.INSTANCE.getFolder(realPath)
       ];
     }
     return result;
   }
 }