Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issue 2956073002: [merge to 3142] Revert "Fix failing ServiceWorkerVersionBrowserTest on Network Service bots" (Closed)

Created:
3 years, 5 months ago by shimazu
Modified:
3 years, 5 months ago
Reviewers:
falken, kinuko, yzshen1, shimazu
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3142
Project:
chromium
Visibility:
Public.

Description

[merge to 3142] Revert "Fix failing ServiceWorkerVersionBrowserTest on Network Service bots" This reverts commit 46a89e2b08fbc0026635f9e4ee3dad2816bc3257. Reason for revert: This patch depends on https://crrev.com/1ebf3cb which is being reverted. See also the bug: https://crbug.com/736649 Original change's description: > Fix failing ServiceWorkerVersionBrowserTest on Network Service bots > > We needed some work-around as we're giving a loading request associated > with EmbeddedWorkerClient to Network Service's URLLoaderFactory. > > BUG=736362 > > Change-Id: I2e64a93b1699b34146d414f64ee00bc50d5455bc > Reviewed-on: https://chromium-review.googlesource.com/547160 > Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>; > Reviewed-by: Makoto Shimazu <shimazu@chromium.org>; > Cr-Commit-Position: refs/heads/master@{#482244} TBR=falken@chromium.org,kinuko@chromium.org,yzshen@chromium.org,shimazu@chromium.org Change-Id: I8bc6dab815c8e4f1834a3f2cbe43d078b46d56fb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 736362, 736649 Reviewed-on: https://chromium-review.googlesource.com/549596 Reviewed-by: Makoto Shimazu <shimazu@chromium.org>; Commit-Queue: Makoto Shimazu <shimazu@chromium.org>; Cr-Original-Commit-Position: refs/heads/master@{#482512} Review-Url: https://codereview.chromium.org/2956073002 . Cr-Commit-Position: refs/branch-heads/3142@{#3} Cr-Branched-From: 58a8bea874fcfa2c18749645f087d0b21b8a21a0-refs/heads/master@{#482491} Committed: https://chromium.googlesource.com/chromium/src/+/451198c115a46ca0b20988954370b743d6acf301

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -42 lines) Patch
M content/browser/service_worker/service_worker_provider_host.cc View 2 chunks +2 lines, -42 lines 0 comments Download
M testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
shimazu
3 years, 5 months ago (2017-06-27 13:45:36 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
451198c115a46ca0b20988954370b743d6acf301.

Powered by Google App Engine
This is Rietveld 408576698