Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: content/browser/accessibility/browser_accessibility_manager.cc

Issue 2956053005: Keep track of fixed positioning in accessibility tree.
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility_manager.cc
diff --git a/content/browser/accessibility/browser_accessibility_manager.cc b/content/browser/accessibility/browser_accessibility_manager.cc
index 30099107b3367fd38b4c252f607dfce51932bd38..cfecd78813b7aef6f59e69a1cc4a6631a1b2b875 100644
--- a/content/browser/accessibility/browser_accessibility_manager.cc
+++ b/content/browser/accessibility/browser_accessibility_manager.cc
@@ -361,6 +361,7 @@ void BrowserAccessibilityManager::OnAccessibilityEvents(
// Process all changes to the accessibility tree first.
for (uint32_t index = 0; index < details.size(); ++index) {
const AXEventNotificationDetails& detail = details[index];
+ LOG(ERROR) << detail.update.ToString();
if (!tree_->Unserialize(detail.update)) {
if (delegate_) {
LOG(ERROR) << tree_->error();
@@ -466,6 +467,7 @@ void BrowserAccessibilityManager::OnAccessibilityEvents(
void BrowserAccessibilityManager::OnLocationChanges(
const std::vector<AccessibilityHostMsg_LocationChangeParams>& params) {
+ LOG(ERROR) << "OnLocationChanges";
for (size_t i = 0; i < params.size(); ++i) {
BrowserAccessibility* obj = GetFromID(params[i].id);
if (!obj)
@@ -473,7 +475,9 @@ void BrowserAccessibilityManager::OnLocationChanges(
ui::AXNode* node = obj->node();
node->SetLocation(params[i].new_location.offset_container_id,
params[i].new_location.bounds,
- params[i].new_location.transform.get());
+ params[i].new_location.transform.get(),
+ params[i].new_location.is_fixed_positioned);
+ LOG(ERROR) << "Location update: " << node->data().ToString();
}
SendLocationChangeEvents(params);
}

Powered by Google App Engine
This is Rietveld 408576698