content/browser/accessibility/accessibility_tree_formatter_blink.cc - Issue 2956053005: Keep track of fixed positioning in accessibility tree.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/accessibility_tree_formatter_blink.cc

Issue 2956053005: Keep track of fixed positioning in accessibility tree.

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/extensions/automation_internal_custom_bindings.cc ('k') | content/browser/accessibility/browser_accessibility_manager.cc » ('j') | third_party/WebKit/Source/modules/accessibility/AXSpinButton.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/accessibility_tree_formatter_blink.cc

diff --git a/content/browser/accessibility/accessibility_tree_formatter_blink.cc b/content/browser/accessibility/accessibility_tree_formatter_blink.cc

index 71f1ea15d9991399a44aa9cc9b2c0ae7d67ae97d..32e6b6819443a269e1fd5b2a9fb8cb5616c94c42 100644

--- a/content/browser/accessibility/accessibility_tree_formatter_blink.cc

+++ b/content/browser/accessibility/accessibility_tree_formatter_blink.cc

@@ -60,6 +60,8 @@ void AccessibilityTreeFormatterBlink::AddProperties(

dict->SetInteger("boundsHeight", bounds.height());

gfx::Rect page_bounds = node.GetPageBoundsRect();

+ LOG(ERROR) << page_bounds.y() << " page bounds for "

aboxhall 2017/06/30 06:07:40 Stray log? Looks like there's a few.

dmazzoni 2017/07/06 07:20:22 Fixed all, sorry about that

+ << node.GetData().ToString();

dict->SetInteger("pageBoundsX", page_bounds.x());

dict->SetInteger("pageBoundsY", page_bounds.y());

dict->SetInteger("pageBoundsWidth", page_bounds.width());