Chromium Code Reviews Chromium Code Reviews
Issue
2956053003:
Revert of [translate] Defer start of translate ranker model load to first use. (patchset #2 id:4000… (Closed)
DescriptionRevert of [translate] Defer start of translate ranker model load to first use. (patchset #2 id:40001 of https://codereview.chromium.org/2871843003/ )
Reason for revert:
The perf regression was not caused by this piece of code. Reverting to the original behavior.
See https://docs.google.com/document/d/1eeTSJg18rJ4v_oxxSJU8MK20UywnEhocWk_WrWv8kQE/edit for details of the regression investigation.
Original issue's description:
> [translate] Defer start of translate ranker model load to first use.
>
> This CL is in response to perf regression (see referenced bugs).
>
> BUG=697947, 697665
>
> Review-Url: https://codereview.chromium.org/2871843003
> Cr-Commit-Position: refs/heads/master@{#471086}
> Committed: https://chromium.googlesource.com/chromium/src/+/d2876f4ee1c1a01ee262ca55752503ba3a30a6d5
TBR=benhenry@chromium.org,vmiura@chromium.org,sullivan@chromium.org,tdresser@chromium.org,groby@chromium.org,rogerm@chromium.org
BUG=697947, 697665
Review-Url: https://codereview.chromium.org/2918173002
Cr-Original-Commit-Position: refs/heads/master@{#478379}
Review-Url: https://codereview.chromium.org/2956053003 .
Cr-Commit-Position: refs/branch-heads/3112@{#481}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
Committed: https://chromium.googlesource.com/chromium/src/+/ac979d32d6ce857f746f44bb009b180676b3114a
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
|||||||||||||||||||
