Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2956033003: Use macros for SequenceChecker docs. (Closed)

Created:
3 years, 5 months ago by Ilya Sherman
Modified:
3 years, 5 months ago
Reviewers:
fdoray
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use macros for SequenceChecker docs. Macros are preferred to direct access to class methods, as they are less expensive in production code. BUG=689520 TEST=none R=fdoray@chromium.org Review-Url: https://codereview.chromium.org/2956033003 Cr-Commit-Position: refs/heads/master@{#482707} Committed: https://chromium.googlesource.com/chromium/src/+/8c33b8a66a28e507d10c2425d94554977543f259

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M docs/threading_and_tasks.md View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Ilya Sherman
3 years, 5 months ago (2017-06-27 18:48:08 UTC) #1
fdoray
lgtm
3 years, 5 months ago (2017-06-27 19:13:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2956033003/1
3 years, 5 months ago (2017-06-27 19:14:40 UTC) #8
commit-bot: I haz the power
3 years, 5 months ago (2017-06-27 19:18:51 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8c33b8a66a28e507d10c2425d945...

Powered by Google App Engine
This is Rietveld 408576698