Print Preview: Make useCloudPrint a WebUI event

Print Preview: Make useCloudPrint a WebUI event

Remove the setUseCloudPrint global JS function and CallJSFunctionUnsafe
and replace with a use-cloud-print WebUI event.

BUG=717296
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2956033002
Cr-Commit-Position: refs/heads/master@{#482860}
Committed: https://chromium.googlesource.com/chromium/src/+/437ea01a74fe57d58ef6e26c9579cebf60819b11

[rbpotter, 2017-06-27 04:54:36]

Description was changed from

==========
Print Preview: Make useCloudPrint a WebUI event

Remove the setUseCloudPrint global JS function and CallJSFunctionUnsafe
and replace with a use-cloud-print WebUI event.

BUG=717296
==========

to

==========
Print Preview: Make useCloudPrint a WebUI event

Remove the setUseCloudPrint global JS function and CallJSFunctionUnsafe
and replace with a use-cloud-print WebUI event.

BUG=717296
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[rbpotter, 2017-06-27 04:56:41]

The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-27 04:56:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rbpotter, 2017-06-27 04:57:26]

Description was changed from

==========
Print Preview: Make useCloudPrint a WebUI event

Remove the setUseCloudPrint global JS function and CallJSFunctionUnsafe
and replace with a use-cloud-print WebUI event.

BUG=717296
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Print Preview: Make useCloudPrint a WebUI event

Remove the setUseCloudPrint global JS function and CallJSFunctionUnsafe
and replace with a use-cloud-print WebUI event.

BUG=717296
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[rbpotter, 2017-06-27 04:57:26]

rbpotter@chromium.org changed reviewers:
+ dpapad@chromium.org

[commit-bot: I haz the power, 2017-06-27 06:16:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-27 06:16:11]

Dry run: This issue passed the CQ dry run.

[dpapad, 2017-06-27 18:54:08]

https://codereview.chromium.org/2956033002/diff/1/chrome/browser/ui/webui/pri...
File chrome/browser/ui/webui/print_preview/print_preview_handler.cc (right):

https://codereview.chromium.org/2956033002/diff/1/chrome/browser/ui/webui/pri...
chrome/browser/ui/webui/print_preview/print_preview_handler.cc:1440:
FireWebUIListener("use-cloud-print", settings);
Do we need to package the string and the boolean to a single object anymore?
FireWebUIListener() supports multiple arguments.

[rbpotter, 2017-06-27 22:20:31]

The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-27 22:20:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rbpotter, 2017-06-27 22:28:05]

The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-27 22:28:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rbpotter, 2017-06-27 22:30:30]

https://codereview.chromium.org/2956033002/diff/1/chrome/browser/ui/webui/pri...
File chrome/browser/ui/webui/print_preview/print_preview_handler.cc (right):

https://codereview.chromium.org/2956033002/diff/1/chrome/browser/ui/webui/pri...
chrome/browser/ui/webui/print_preview/print_preview_handler.cc:1440:
FireWebUIListener("use-cloud-print", settings);
On 2017/06/27 18:54:07, dpapad wrote:
> Do we need to package the string and the boolean to a single object anymore?
> FireWebUIListener() supports multiple arguments.

Done.

https://codereview.chromium.org/2956033002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/print_preview/print_preview.js (right):

https://codereview.chromium.org/2956033002/diff/40001/chrome/browser/resource...
chrome/browser/resources/print_preview/print_preview.js:699: cloudPrintUrl,
this.nativeLayer_, this.userInfo_, appKioskMode);
Note: there is now no reason cloudPrintUrl or appKioskMode should ever
be undefined.

[dpapad, 2017-06-27 23:26:33]

lgtm

[commit-bot: I haz the power, 2017-06-28 00:33:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-28 00:33:01]

Dry run: This issue passed the CQ dry run.

[rbpotter, 2017-06-28 02:36:44]

The CQ bit was checked by rbpotter@chromium.org

[commit-bot: I haz the power, 2017-06-28 02:36:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 02:41:50]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498617404546280,
"parent_rev": "2820c5be459b2a37f590580ae9b1a14cea967020", "commit_rev":
"437ea01a74fe57d58ef6e26c9579cebf60819b11"}

[commit-bot: I haz the power, 2017-06-28 02:42:08]

Description was changed from

==========
Print Preview: Make useCloudPrint a WebUI event

Remove the setUseCloudPrint global JS function and CallJSFunctionUnsafe
and replace with a use-cloud-print WebUI event.

BUG=717296
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Print Preview: Make useCloudPrint a WebUI event

Remove the setUseCloudPrint global JS function and CallJSFunctionUnsafe
and replace with a use-cloud-print WebUI event.

BUG=717296
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2956033002
Cr-Commit-Position: refs/heads/master@{#482860}
Committed:
https://chromium.googlesource.com/chromium/src/+/437ea01a74fe57d58ef6e26c9579...
==========

[commit-bot: I haz the power, 2017-06-28 02:42:09]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/437ea01a74fe57d58ef6e26c9579...