Update Chrome Upstream flow to reflect new UI mocks

chrome/browser/ui/views/autofill/save_card_bubble_views.h

Index: chrome/browser/ui/views/autofill/save_card_bubble_views.h
diff --git a/chrome/browser/ui/views/autofill/save_card_bubble_views.h b/chrome/browser/ui/views/autofill/save_card_bubble_views.h
index 797d05d1e4c51f84656711f6eaea1c8ace352af4..799949706f0f16e3ed47a8a3cb759bcecc323965 100644
--- a/chrome/browser/ui/views/autofill/save_card_bubble_views.h
+++ b/chrome/browser/ui/views/autofill/save_card_bubble_views.h
@@ -45,6 +45,9 @@ class SaveCardBubbleViews : public SaveCardBubbleView,
   // SaveCardBubbleView
   void Hide() override;
 
+  // views::DialogDelegate
+  int GetDialogButtons() const override;
+
   // views::BubbleDialogDelegateView
   views::View* CreateExtraView() override;
   views::View* CreateFootnoteView() override;
@@ -58,6 +61,7 @@ class SaveCardBubbleViews : public SaveCardBubbleView,
   gfx::Size CalculatePreferredSize() const override;
 
   // views::WidgetDelegate
+  bool ShouldShowCloseButton() const override;

[jiahuiguo, 2017/06/27 01:21:10]

Should we add a "Should" here? Looks ShowCloseButton() is enough?

[Jared Saul, 2017/06/27 01:31:47]

It's overriding a method in views::WidgetDelegate:
https://cs.chromium.org/chromium/src/ui/views/widget/widget_delegate.h?l=87&r...

   base::string16 GetWindowTitle() const override;
   void WindowClosing() override;
 
@@ -74,8 +78,20 @@ class SaveCardBubbleViews : public SaveCardBubbleView,
                        const base::string16& new_contents) override;
 
  private:
+  // The current step of the save card flow.  Accounts for:
+  //  1) Local save vs. Upload save
+  //  2) Upload save can have all information or be missing CVC
+  enum CurrentFlowStep {
+    UNKNOWN_STEP,
+    LOCAL_SAVE_ONLY_STEP,
+    UPLOAD_SAVE_ONLY_STEP,
+    UPLOAD_SAVE_CVC_FIX_FLOW_STEP_1,

[Shanfeng, 2017/06/27 04:00:31]

It would be better if replace step_1 with a more specific name.  ditto for step
2.

[Jared Saul, 2017/06/27 16:38:02]

I kept the STEP_1 and STEP_2 parts so it's clear what order these things happen
in, but I added _OFFER_UPLOAD and _REQUEST_CVC to make it more descriptive about
what each step entails.

+    UPLOAD_SAVE_CVC_FIX_FLOW_STEP_2,
+  };
+
   ~SaveCardBubbleViews() override;
 
+  CurrentFlowStep GetCurrentFlowStep() const;
   std::unique_ptr<views::View> CreateMainContentView();
   std::unique_ptr<views::View> CreateRequestCvcView();
 
@@ -84,6 +100,8 @@ class SaveCardBubbleViews : public SaveCardBubbleView,
 
   SaveCardBubbleController* controller_;  // Weak reference.
 
+  views::View* footnote_view_ = nullptr;
+
   ViewStack* view_stack_ = nullptr;
 
   views::Textfield* cvc_textfield_ = nullptr;