Chromium Code Reviews| Index: chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc |
| diff --git a/chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc b/chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc |
| index fdc9a997ed73e5d8d6cb8787c25f81fb90fcff4c..a46dc806470750b5bea40727dfb752bd4f87c70f 100644 |
| --- a/chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc |
| +++ b/chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc |
| @@ -393,26 +393,26 @@ TEST_F(SaveCardBubbleControllerImplTest, |
| AutofillMetrics::SAVE_CARD_PROMPT_END_NAVIGATION_HIDDEN, 1); |
| } |
| -TEST_F(SaveCardBubbleControllerImplTest, Metrics_Upload_FirstShow_LearnMore) { |
| - ShowUploadBubble(); |
| +TEST_F(SaveCardBubbleControllerImplTest, Metrics_Local_FirstShow_LearnMore) { |
| + ShowLocalBubble(); |
| base::HistogramTester histogram_tester; |
| controller()->OnLearnMoreClicked(); |
| histogram_tester.ExpectUniqueSample( |
| - "Autofill.SaveCreditCardPrompt.Upload.FirstShow", |
| + "Autofill.SaveCreditCardPrompt.Local.FirstShow", |
| AutofillMetrics::SAVE_CARD_PROMPT_DISMISS_CLICK_LEARN_MORE, 1); |
| } |
| -TEST_F(SaveCardBubbleControllerImplTest, Metrics_Upload_Reshows_LearnMore) { |
|
jiahuiguo
2017/06/27 01:21:10
Do we have tests for the Upload part?
Jared Saul
2017/06/27 01:31:46
We had them; I'm getting rid of them because the "
|
| - ShowUploadBubble(); |
| +TEST_F(SaveCardBubbleControllerImplTest, Metrics_Local_Reshows_LearnMore) { |
| + ShowLocalBubble(); |
| CloseAndReshowBubble(); |
| base::HistogramTester histogram_tester; |
| controller()->OnLearnMoreClicked(); |
| histogram_tester.ExpectUniqueSample( |
| - "Autofill.SaveCreditCardPrompt.Upload.Reshows", |
| + "Autofill.SaveCreditCardPrompt.Local.Reshows", |
| AutofillMetrics::SAVE_CARD_PROMPT_DISMISS_CLICK_LEARN_MORE, 1); |
| } |