Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2955943002: DevTools: migrate inspector-protocol/dom tests to a new test runner (Closed)

Created:
3 years, 5 months ago by lushnikov
Modified:
3 years, 5 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: migrate inspector-protocol/dom tests to a new test runner This patch: - migrates all the tests from inspector-protocol/dom to a new test runner - fixes test dom-setOuterHTML.js. It was not doing anything before - changes testRunner.evaluate{,Async} to allow function as an argument - introduces NodeTracker helper class to track nodes R=dgozman Review-Url: https://codereview.chromium.org/2955943002 Cr-Commit-Position: refs/heads/master@{#482537} Committed: https://chromium.googlesource.com/chromium/src/+/d8b6e8c582c37920b0de358c3835a1d99fbe56df

Patch Set 1 #

Patch Set 2 : address comments #

Patch Set 3 : rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1570 lines, -2281 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-childNodeCount.html View 1 chunk +0 lines, -69 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-childNodeCount.js View 1 1 chunk +35 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-childNodeCount-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-collect-class-names.html View 1 chunk +0 lines, -71 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-collect-class-names.js View 1 1 chunk +43 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-collect-class-names-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-focus.html View 1 chunk +0 lines, -52 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-focus.js View 1 1 chunk +19 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-focus-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-getBoxModel.html View 1 chunk +0 lines, -65 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-getBoxModel.js View 1 1 chunk +26 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-getBoxModel-expected.txt View 1 chunk +2 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-getEventListeners.html View 1 chunk +0 lines, -74 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-getEventListeners.js View 1 1 chunk +53 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-getEventListeners-expected.txt View 1 chunk +127 lines, -130 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-getFlattenedDocument.html View 1 chunk +0 lines, -55 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-getFlattenedDocument.js View 1 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-getFlattenedDocument-expected.txt View 1 1 chunk +401 lines, -438 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-getNodeForLocation.html View 1 chunk +0 lines, -40 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-getNodeForLocation.js View 1 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-getNodeForLocation-expected.txt View 1 chunk +4 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-getNodeForLocation-skip-shadow.html View 1 chunk +0 lines, -42 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-getNodeForLocation-skip-shadow.js View 1 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-getNodeForLocation-skip-shadow-expected.txt View 1 chunk +5 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-ns-attr-modified.html View 1 chunk +0 lines, -61 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-ns-attr-modified.js View 1 1 chunk +30 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-ns-attr-modified-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-relayout-boundary.html View 1 chunk +0 lines, -137 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-relayout-boundary.js View 1 1 chunk +57 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-relayout-boundary-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-request-child-nodes-depth.html View 1 chunk +0 lines, -165 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-request-child-nodes-depth.js View 1 1 chunk +78 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-request-child-nodes-depth-expected.txt View 2 chunks +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-request-child-nodes-traverse-frames.html View 1 chunk +0 lines, -106 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-request-child-nodes-traverse-frames.js View 1 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-request-child-nodes-traverse-frames-expected.txt View 1 chunk +130 lines, -124 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-request-document-with-child-nodes.html View 1 chunk +0 lines, -83 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-request-document-with-child-nodes.js View 1 1 chunk +23 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-request-document-with-child-nodes-expected.txt View 1 chunk +278 lines, -221 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-setInspectModeEnabled.html View 1 chunk +0 lines, -54 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-setInspectModeEnabled.js View 1 1 chunk +23 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-setInspectModeEnabled-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-setOuterHTML.html View 1 chunk +0 lines, -53 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-setOuterHTML.js View 1 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-setOuterHTML-expected.txt View 1 chunk +8 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-svg-attribute-case.html View 1 chunk +0 lines, -87 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-svg-attribute-case.js View 1 1 chunk +21 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-svg-attribute-case-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/dom/push-children-on-pseudo-addition.html View 1 chunk +0 lines, -130 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/dom/push-children-on-pseudo-addition.js View 1 1 chunk +34 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/dom/push-children-on-pseudo-addition-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/dom/resources/dom-getFlattenedDocument.html View 1 1 chunk +25 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/dom/resources/dom-request-child-nodes-traverse-frames.html View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/resources/dom-helper.js View 1 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/resources/inspector-protocol-test.js View 1 6 chunks +12 lines, -5 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/resources/node-tracker.js View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
lushnikov
please, take a look
3 years, 5 months ago (2017-06-26 23:31:44 UTC) #3
dgozman
lgtm
3 years, 5 months ago (2017-06-27 00:14:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2955943002/20001
3 years, 5 months ago (2017-06-27 00:22:54 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/246236) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 5 months ago (2017-06-27 00:26:08 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2955943002/40001
3 years, 5 months ago (2017-06-27 03:08:50 UTC) #15
commit-bot: I haz the power
3 years, 5 months ago (2017-06-27 04:23:55 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d8b6e8c582c37920b0de358c3835...

Powered by Google App Engine
This is Rietveld 408576698