Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2955803002: Propogate kUnsafelyTreatInsecureOriginAsSecure flag to the zygote process (Closed)

Created:
3 years, 6 months ago by raymes
Modified:
3 years, 5 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Propogate kUnsafelyTreatInsecureOriginAsSecure flag to the zygote process ChromeContentClient::AddAdditionalSchemes sets up the global whitelisted origins. Some of these origins may be passed in via the kUnsafelyTreatInsecureOriginsAsSecure flag. However, this call happens while the renderer process is still a zygote on linux. This means that content::IsOriginSecure checks won't take these whitelisted origins into account. BUG=736140 Review-Url: https://codereview.chromium.org/2955803002 Cr-Commit-Position: refs/heads/master@{#482353} Committed: https://chromium.googlesource.com/chromium/src/+/998231b917858c87b641040c742f5cc41ac9b43e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
raymes
3 years, 6 months ago (2017-06-26 02:56:58 UTC) #4
Lei Zhang
lgtm
3 years, 5 months ago (2017-06-26 19:20:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2955803002/1
3 years, 5 months ago (2017-06-26 19:20:29 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2017-06-26 19:29:43 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/998231b917858c87b641040c742f...

Powered by Google App Engine
This is Rietveld 408576698