Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2955783003: Call matching method on delegate (Closed)

Created:
3 years, 5 months ago by Felix Ekblom
Modified:
3 years, 5 months ago
Reviewers:
dmazzoni, sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Call matching method on delegate Fix possible type and call delegate method with matching name. BUG=662501 Review-Url: https://codereview.chromium.org/2955783003 Cr-Commit-Position: refs/heads/master@{#482461} Committed: https://chromium.googlesource.com/chromium/src/+/80e7ad9bbb7e8d04e88b4793644c449b1c3d23e0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ash/ash_touch_exploration_manager_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Felix Ekblom
3 years, 5 months ago (2017-06-26 15:00:43 UTC) #3
dmazzoni
Thanks for the fix!
3 years, 5 months ago (2017-06-26 15:58:50 UTC) #4
dmazzoni
lgtm
3 years, 5 months ago (2017-06-26 15:59:00 UTC) #5
sky
LGTM
3 years, 5 months ago (2017-06-26 17:05:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2955783003/1
3 years, 5 months ago (2017-06-26 22:53:27 UTC) #8
commit-bot: I haz the power
3 years, 5 months ago (2017-06-26 23:29:24 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/80e7ad9bbb7e8d04e88b4793644c...

Powered by Google App Engine
This is Rietveld 408576698