Filter QUIC alternative service if the versions advertised by the server

net/spdy/chromium/spdy_session_unittest.cc

Index: net/spdy/chromium/spdy_session_unittest.cc
diff --git a/net/spdy/chromium/spdy_session_unittest.cc b/net/spdy/chromium/spdy_session_unittest.cc
index d14187178359083d05129043012d0ae7d276fdcc..daeb96b1e9f4607f2c4da17ebe11335923d066fd 100644
--- a/net/spdy/chromium/spdy_session_unittest.cc
+++ b/net/spdy/chromium/spdy_session_unittest.cc
@@ -5657,6 +5657,41 @@ TEST_F(AltSvcFrameTest, ProcessAltSvcFrame) {
   EXPECT_EQ(alternative_service, altsvc_info_vector[0].alternative_service());
 }
 
+// Regression test for crbug.com/736063.

[Bence, 2017/06/26 15:44:53]

Optional: https://crbug.com/736063.  Because https everywhere!, also because
some tools that developers might use (like vim in gnome-terminal) would not
parse it as a clickable link without the https:// prefix.

[Zhongyi Shi, 2017/06/26 17:29:18]

Done. Good point!

+TEST_F(AltSvcFrameTest, IgnoreQuicAltSvcWithUnsupportedVersion) {
+  const char origin[] = "https://mail.example.org";
+  SpdyAltSvcIR altsvc_ir(/* stream_id = */ 0);
+  SpdyAltSvcWireFormat::AlternativeService quic_alternative_service(
+      "quic", "alternative.example.org", 443, 86400,
+      SpdyAltSvcWireFormat::VersionVector());
+  // TODO(zhongyi): SpdyAltSvcWireFormat::ParseHeaderFieldValue expects positve
+  // versions while VersionVector allows nonnegative verisons.
+  // Fix the parse function and change the hardcode invliad version to

[Bence, 2017/06/26 15:44:53]

Optional: s/hardcode/hardcoded/, if I understand the context correctly.

[Bence, 2017/06/26 15:44:53]

s/invliad/invalid/

[Zhongyi Shi, 2017/06/26 17:29:19]

Done.

+  // QUIC_VERSION_UNSUPPORTED.
+  quic_alternative_service.version.push_back(/* invalid QUIC version */ 1);
+  altsvc_ir.add_altsvc(quic_alternative_service);
+  altsvc_ir.set_origin(origin);
+  AddSocketData(altsvc_ir);
+  AddSSLSocketData();
+
+  CreateNetworkSession();
+  CreateSecureSpdySession();
+
+  base::RunLoop().RunUntilIdle();
+
+  const url::SchemeHostPort session_origin("https", test_url_.host(),
+                                           test_url_.EffectiveIntPort());
+  AlternativeServiceInfoVector altsvc_info_vector =
+      spdy_session_pool_->http_server_properties()->GetAlternativeServiceInfos(
+          session_origin);
+  ASSERT_TRUE(altsvc_info_vector.empty());
+
+  altsvc_info_vector =
+      spdy_session_pool_->http_server_properties()->GetAlternativeServiceInfos(
+          url::SchemeHostPort(GURL(origin)));
+  ASSERT_EQ(0u, altsvc_info_vector.size());
+}
+
 TEST_F(AltSvcFrameTest, DoNotProcessAltSvcFrameOnInsecureSession) {
   const char origin[] = "https://mail.example.org";
   SpdyAltSvcIR altsvc_ir(/* stream_id = */ 0);