Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 2955623003: In mushrome, keep the state of the cursor locally. (Closed)

Created:
3 years, 6 months ago by Elliot Glaysher
Modified:
3 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

In mushrome, keep the state of the cursor locally. In addition to telling the window server about state changes, record them locally in the window manager so that queries about the current cursor state return the correct values. BUG=734806 Review-Url: https://codereview.chromium.org/2955623003 Cr-Commit-Position: refs/heads/master@{#482102} Committed: https://chromium.googlesource.com/chromium/src/+/bf104c1b3d2dfae83774369a9c6a890ad57b9d6e

Patch Set 1 #

Total comments: 1

Patch Set 2 : c++11 loop #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M ash/wm/native_cursor_manager_ash_mus.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M testing/buildbot/filters/ash_unittests_mus.filter View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Elliot Glaysher
Even though this doesn't do anything about displaying the cursor, we still need to maintain ...
3 years, 6 months ago (2017-06-23 22:59:39 UTC) #4
sky
LGTM https://codereview.chromium.org/2955623003/diff/1/ash/wm/native_cursor_manager_ash_mus.cc File ash/wm/native_cursor_manager_ash_mus.cc (right): https://codereview.chromium.org/2955623003/diff/1/ash/wm/native_cursor_manager_ash_mus.cc#newcode50 ash/wm/native_cursor_manager_ash_mus.cc:50: for (aura::Window::Windows::iterator iter = root_windows.begin(); for (aura::Window* root ...
3 years, 6 months ago (2017-06-23 23:31:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2955623003/20001
3 years, 6 months ago (2017-06-23 23:35:35 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-24 01:01:25 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bf104c1b3d2dfae83774369a9c6a...

Powered by Google App Engine
This is Rietveld 408576698