|
|
Created:
3 years, 6 months ago by ikilpatrick Modified:
3 years, 5 months ago CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews, lchoi+reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[LayoutNG] Stretch content size of BFCs to encapsulate floats.
Just a simple fix to make sure that BFC stretch to fit all of the floats inside them.
BUG=635619
Review-Url: https://codereview.chromium.org/2955613002
Cr-Commit-Position: refs/heads/master@{#483494}
Committed: https://chromium.googlesource.com/chromium/src/+/d1e96b7ddea88fa9219478bfbd04f94772e31718
Patch Set 1 #Patch Set 2 : ... #Patch Set 3 : TestExpectations #Patch Set 4 : TestExpectations #
Messages
Total messages: 25 (21 generated)
Description was changed from ========== [LayoutNG] Stretch content size of BFCs to encapsulate floats. BUG= ========== to ========== [LayoutNG] Stretch content size of BFCs to encapsulate floats. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng ==========
The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_layout_tests_layout_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)
The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [LayoutNG] Stretch content size of BFCs to encapsulate floats. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng ========== to ========== [LayoutNG] Stretch content size of BFCs to encapsulate floats. Just a simple fix to make sure that BFC stretch to fit all of the floats inside them. BUG=635619 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng ==========
ikilpatrick@chromium.org changed reviewers: + cbiesinger@chromium.org, eae@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_layout_tests_layout_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)
The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_layout_tests_layout_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)
Description was changed from ========== [LayoutNG] Stretch content size of BFCs to encapsulate floats. Just a simple fix to make sure that BFC stretch to fit all of the floats inside them. BUG=635619 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng ========== to ========== [LayoutNG] Stretch content size of BFCs to encapsulate floats. Just a simple fix to make sure that BFC stretch to fit all of the floats inside them. BUG=635619 ==========
The CQ bit was checked by ikilpatrick@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 60001, "attempt_start_ts": 1498771917374870, "parent_rev": "c6c69f142078d6c00992cf57a8301dcafb68d3e4", "commit_rev": "d1e96b7ddea88fa9219478bfbd04f94772e31718"}
Message was sent while issue was closed.
Description was changed from ========== [LayoutNG] Stretch content size of BFCs to encapsulate floats. Just a simple fix to make sure that BFC stretch to fit all of the floats inside them. BUG=635619 ========== to ========== [LayoutNG] Stretch content size of BFCs to encapsulate floats. Just a simple fix to make sure that BFC stretch to fit all of the floats inside them. BUG=635619 Review-Url: https://codereview.chromium.org/2955613002 Cr-Commit-Position: refs/heads/master@{#483494} Committed: https://chromium.googlesource.com/chromium/src/+/d1e96b7ddea88fa9219478bfbd04... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/d1e96b7ddea88fa9219478bfbd04... |