Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Issue 2955613002: [LayoutNG] Stretch content size of BFCs to encapsulate floats. (Closed)

Created:
3 years, 6 months ago by ikilpatrick
Modified:
3 years, 5 months ago
Reviewers:
cbiesinger, eae
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews, lchoi+reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Stretch content size of BFCs to encapsulate floats. Just a simple fix to make sure that BFC stretch to fit all of the floats inside them. BUG=635619 Review-Url: https://codereview.chromium.org/2955613002 Cr-Commit-Position: refs/heads/master@{#483494} Committed: https://chromium.googlesource.com/chromium/src/+/d1e96b7ddea88fa9219478bfbd04f94772e31718

Patch Set 1 #

Patch Set 2 : ... #

Patch Set 3 : TestExpectations #

Patch Set 4 : TestExpectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 10 chunks +0 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 1 2 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (21 generated)
ikilpatrick
3 years, 5 months ago (2017-06-28 21:50:17 UTC) #10
cbiesinger
lgtm
3 years, 5 months ago (2017-06-29 19:51:34 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2955613002/60001
3 years, 5 months ago (2017-06-29 21:32:20 UTC) #22
commit-bot: I haz the power
3 years, 5 months ago (2017-06-29 21:37:13 UTC) #25
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/d1e96b7ddea88fa9219478bfbd04...

Powered by Google App Engine
This is Rietveld 408576698