Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2955573002: VM-codegen: Prefer simpler is-check variant where possible (Closed)

Created:
3 years, 6 months ago by erikcorry
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM-codegen: Prefer simpler is-check variant where possible Before we try anything more complex, check whether there is only one class that satisfies an 'is' check. If so, we can just check for that class id and deopt when new classes are defined. This change merely reverses the order of existing code. This is a reland of https://codereview.chromium.org/2899283002 after an unrelated bug that caused a crash was fixed at https://github.com/dart-lang/sdk/issues/29774 R=kustermann@google.com, vegorov@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/b192ecfb24d973e700703dbaab336d55668ae804

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -14 lines) Patch
M runtime/vm/jit_optimizer.cc View 2 chunks +15 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
erikcorry
3 years, 6 months ago (2017-06-23 08:22:47 UTC) #1
Vyacheslav Egorov (Google)
lgtm
3 years, 6 months ago (2017-06-23 10:58:50 UTC) #3
erikcorry
3 years, 6 months ago (2017-06-24 12:02:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b192ecfb24d973e700703dbaab336d55668ae804 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698