Issue 2899283002: Prefer single CID test for 'is' operator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2899283002: Prefer single CID test for 'is' operator (Closed)

Created:
3 years, 7 months ago by erikcorry

Modified:
3 years, 6 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Prefer single CID test for 'is' operator Before we try anything more complex, check whether there is only one class that satisfies an 'is' check. If so, we can just check for that class id and deopt when new classes are defined. This change merely reverses the order of existing code. R=kustermann@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/56e93fa2b0e1256addfe396858c572c216f28ab5

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -14 lines)			Patch
	M	runtime/vm/jit_optimizer.cc	View		2 chunks	+15 lines, -14 lines	0 comments	Download

Total messages: 4 (1 generated)

erikcorry

3 years, 6 months ago (2017-05-29 08:02:19 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
56e93fa2b0e1256addfe396858c572c216f28ab5 (presubmit successful).